Do not check if room param is NaN in basic example server. #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isNaN('inputRoomName') returns true. Given a string of specific room name,
original implementation never assigns the specific room name to the
variable, resulting in generating new token of default room.
Remove the isNaN() call and simply check if the input value is truthy just
like what we do on other parameters.
jcague
approved these changes
May 30, 2018
zevarito
pushed a commit
to zevarito/licode
that referenced
this pull request
Jul 4, 2018
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isNaN('inputRoomName') returns true. Given a string of specific room name,
original implementation never assigns the specific room name to the
variable, resulting in generating new token of default room.
Remove the isNaN() call and simply check if the input value is truthy just
like what we do on other parameters.
Description
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.