Fix unpublish and unsubscribe for Single PC #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Jul 18, 2018
| @@ -116,22 +128,31 @@ const BaseStack = (specInput) => { | |||
| specBase.callback({ | |||
| type: localDesc.type, | |||
| sdp: localDesc.sdp, | |||
| config: { maxVideoBW: specBase.maxVideoBW }, | |||
| }); | |||
| Logger.info('Setting local description p2p', localDesc); | |||
There was a problem hiding this comment.
Consider updating the log here to show that this doesn't only apply to p2p anymore
| @@ -45,7 +45,7 @@ const Room = (altIo, altConnectionHelpers, altConnectionManager, specInput) => { | |||
| // Private functions | |||
| const removeStream = (streamInput) => { | |||
| const stream = streamInput; | |||
| if (stream.stream) { | |||
| if (stream.stream && !stream.local) { | |||
There was a problem hiding this comment.
Not closing the local stream when unpublishing can be risky in some cases. I'd prefer thinking about how we want to manage this in the API and update it accordingly in another PR
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was some issues in Single Peer Connection when trying to unsubscribe or unpublish streams because we were not negotiating the SDP again. This PR adds such negotiation and it also introduces some minor fixes.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.