Add a new algorithm to allocate better bandwidth in Single PC #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Sep 18, 2018
| remaining_bitrate -= bitrate; | ||
| remaining_streams--; | ||
| }); | ||
| distributor_->distribute(chead->getREMBBitRate(), chead->getSSRC(), streams, transport); |
| @@ -0,0 +1,35 @@ | |||
| /* | |||
| * MaxVideoBWDistributor.cpp | |||
There was a problem hiding this comment.
Do we have this just to keep the code of the previous algorithm? Do you foresee using this algorithm in any case. I'm ok with keeping it but almost every time we've done this in the past we ended up with code that is only updated when the tests fail but is never used.
There was a problem hiding this comment.
I completely agree, I will remove it once we're 100% sure the new code works for all cases.
| uint32_t remaining_avg_bitrate = remaining_bitrate / remaining_streams; | ||
| uint32_t bitrate = std::min(target_bitrate, remaining_avg_bitrate); | ||
| uint32_t remb = std::min(max_bitrate, remaining_avg_bitrate); | ||
| uint32_t bitrate_to_transfer = std::max(bitrate - target_bitrate * 1.2, 0.0); |
There was a problem hiding this comment.
I don't think we need bitrate_to_transfer it will always be 0 unless we have a bug somewhere else. As far as I can tell bitrate is enough to update remaining_bitrate and distribute the bitrate correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The way we were distributing available bandwidth among streams in the same single PC was suboptimal for some cases. This PR aims to improve the algorithm when we use Simulcast and Slideshow.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.