Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize event listener to nullptr #1299

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Sep 19, 2018

Description

media_stream_event_listener_ was not being initialized. That could cause crashes, specially running the slideshowbeloylayer tests in some environments.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lodoyun lodoyun merged commit 520e265 into lynckia:master Sep 20, 2018
@lodoyun lodoyun deleted the fix/mediaStreamNoEventListenerCrash branch October 3, 2019 11:17
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants