BWE Fixes for publisher estimation in chrome >72 #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if it helps, we decided long time ago to terminate all RR and REMBS from subscribers. this is working quite well |
|
@kekkokk That approach should also be valid but I prefer Chrome doing the actual selecting from the lowest REMB if I can. Also, we're potentially getting a more accurate estimation since we're running the full sender side algorithm taking into account delays and packet loss ratio from the subscribers instead of blindly forwarding REMBs, which only paints a part of the picture. |
lodoyun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another possible solution for the bandwidth estimation problems when not using simulcast in Chrome >72.
This PR drops all other RR packets from subscribers and relies on the sender estimation implementation in licode to update REMB from subscribers.
Also, this PR updated RR packets generated in Licode so the packets lost are monotonically increasing. There are different ways to do this but, at this time, we chose to use the packet loss ratio when it's > 0.
If tests are positive, in the future, we will work on separating the logic that decides what RR packets to forward in a new handler.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.