Fix SDP negotiation for resubscriptions #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
This looks good to me! I've been reviewing/inspecting parts of this for a while so it's hard for me to find new things, just a comment for an improvement for the future.
Looking at the end result, and besides the mountain of smaller fixes/improvements, I particularly like the way promises are integrated into erizo and using conan for dependencies 💯
| @@ -83,6 +83,7 @@ const Room = (altIo, altConnectionHelpers, altConnectionManager, specInput) => { | |||
| if (!that.p2p) { | |||
| stream.pc.addStream(stream); | |||
| } | |||
| stream.state = 'subscribed'; | |||
There was a problem hiding this comment.
In the future we should think about having a more involved fsm like we're using in other places. Even maybe just having all the states set as a constant somewhere so we can see all the possible states at a glance would be an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to reapply old commits that solved cases where we want to unsubscribe and subscribe again. It is mainly focused for Single Peer Connection, but it also affects multiple Peer Connections.
The old commits introduced a set of issues like Erizo crashes, negotiation failures, etc. that I have been fixing in this PR with more commits.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.