-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Stream Management in ErizoController #1463
Refactor Stream Management in ErizoController #1463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo comments
@@ -167,6 +180,9 @@ class Client extends events.EventEmitter { | |||
'state: SUBSCRIBER_READY, ' + | |||
`streamId: ${signMess.streamId}, ` + | |||
`clientId: ${this.id}`); | |||
this.roomController | |||
.getPublishedStreamById(signMess.streamId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd check if stream is not undefined
@@ -357,6 +382,141 @@ class Client extends events.EventEmitter { | |||
}); | |||
} | |||
|
|||
_publishExternalInput(id, options, sdp, callback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like all these internal functions!
const dataSubscribers = []; | ||
|
||
that.getID = () => spec.id; | ||
const StreamStates = Object.freeze({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Description
This PR updates #1398 with clean commits, resolved conflicts and a couple of new fixes.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc
.