Implement Pli Priority Handler #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Oct 17, 2019
| if (this_ptr->plis_received_in_interval_ > 0) { | ||
| ELOG_DEBUG("%s, message: Sending Low priority PLI, plis_received_in_interval_: %u", | ||
| this_ptr->stream_->toLog(), this_ptr->plis_received_in_interval_); | ||
| this_ptr->plis_received_in_interval_ = 0; |
There was a problem hiding this comment.
does it make sense to also set first_received_ to false?
There was a problem hiding this comment.
Thats a possible optimization, I would then return false to stop this scheduled Task and have it start again next time a Low priority pli is received... However, I prefer adding a comment for it as a possible improvement in the near future and start testing the functionality.
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a handler that throttles PLI requests based on priority.
All PLI packets are marked with high or low priority. High priority PLIs go directly through the handler but low priority ones are throttled so only 1 is sent every 3 seconds.
Currently the only PLI packets that are marked as low priority are those requested when switching to a higher layer.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.