Remove libnice and glib #1505
Merged
Remove libnice and glib #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Nov 27, 2019
| @@ -54,13 +54,13 @@ check_result() { | |||
| install_homebrew_from_cache(){ | |||
| if [ -f cache/homebrew-cache.tar.gz ]; then | |||
| tar xzf cache/homebrew-cache.tar.gz --directory /usr/local/Cellar | |||
| brew link glib pkg-config boost cmake yasm log4cxx gettext coreutils | |||
| brew link pkg-config boost cmake yasm log4cxx gettext coreutils | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * LibNiceConnection.h | |||
| * IceConnection.h | |||
| @@ -55,7 +55,7 @@ unsigned long ssl_thread_id() { // NOLINT | |||
| } | |||
| #else | |||
| void ssl_thread_id(CRYPTO_THREADID *id) { // NOLINT | |||
| CRYPTO_THREADID_set_numeric(id, (unsigned long)std::hash<std::thread::id>()(std::this_thread::get_id()); // NOLINT | |||
| CRYPTO_THREADID_set_numeric(id, (unsigned long)std::hash<std::thread::id>()(std::this_thread::get_id())); // NOLINT | |||
| @@ -68,8 +66,8 @@ class IceConfig { | |||
| turn_port{0}, | |||
| min_port{0}, | |||
| max_port{0}, | |||
| should_trickle{false}, | |||
| use_nicer{false} { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have been using NiceR for 2+ years without problems. This PR removes the libnice alternative, reducing the maintenance work and the testing that is required to maintain 2 libraries for IO. As a bonus, it should reduce image size and build time in some cases.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.