Skip ice candidate if peer and stream objects are NULL #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call setRemoteCandidates twice to test using of start_future_ in 2 cases: first time and next times.
|
Tests passed only when I allow using peer_ variable only after startSync() has been done (synced by start_promise_). |
jcague
reviewed
Jan 16, 2020
erizo/src/erizo/NicerConnection.cpp
Outdated
| @@ -320,6 +320,16 @@ void NicerConnection::startGathering() { | |||
| } | |||
|
|
|||
| bool NicerConnection::setRemoteCandidates(const std::vector<CandidateInfo> &candidates, bool is_bundle) { | |||
| // At this moment we should have peer_ initalized. To make sure, we are waiting for start_promise_ there | |||
There was a problem hiding this comment.
Shouldn't we make sure we don't call setRemoteCandidates before having started Nicer? I don't like the idea of blocking the thread while we are waiting. Another alternative is to return false and call setRemoteCandidates after a while again.
…chak/licode into vpoddubchak-fix/nicer_crash_with_ios
Merge with master branch and fix unit tests without locking threads
jcague
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround of crash which sometimes happens when iOS client tries to connect to the room. In some cases peer and stream objects are NULL (possible because of race condition) in moment then method nicer->IcePeerContextParseTrickleCandidate is calling.
In cases when skipped ice-candidate is host - all will be OK: connection will be established. But I'm afraid that in cases when we skip srflx candidate it can bring to connection problems. Anyway it is better than crash of the room...