Adapt to new nicer api (work from another's PR) #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to origin
|
@vpoddubchak here I follow your work in #1564 and fixed a couple of things. Let's see if it builds and I'll start testing it with our tools. Thanks a lot for the contribution. I've read the original commits and it looks pretty straightforward to implement ICE refresh now so it looks promising! |
|
This helpful for me,I get crash amostly every time at commit 8a1c... ,Folow the step up modify local code ,it work and not happen again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I took commits from @vpoddubchak PR and fixed some minor issues. I usually do a PR to the other branch, but I can't do it in this case for some unknown reason, maybe because his repo is private.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.