Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logging for basicExample #1596

Merged
merged 7 commits into from
Jun 9, 2020
Merged

Added logging for basicExample #1596

merged 7 commits into from
Jun 9, 2020

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Jun 8, 2020 •
edited
Loading

Description

This PR adds some logging options for basicExample.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

jcague
jcague approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'd rather use log4js to be consistent with other components (erizoAgent, erizoController, ...).

@lodoyun lodoyun changed the title Added very basic logging for basicExample Added logging for basicExample Jun 9, 2020
@lodoyun
Copy link
Contributor Author

lodoyun commented Jun 9, 2020

@jcague I've decided to go with your suggestion and now it uses log4js.

jcague
jcague approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun merged commit bc96a35 into lynckia:master Jun 9, 2020
@lodoyun lodoyun deleted the add/loggingBasicExample branch June 10, 2020 08:42
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@lodoyun
Added logging for basicExample (lynckia#1596)
886a766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lodoyun @jcague