Centralize the way we get configuration flags in BasicExample #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Jul 1, 2020
| window.recordingId = ''; | ||
| let localStream; | ||
| let room; | ||
| let recording = false; |
There was a problem hiding this comment.
We are not setting recording and recordingId to window anymore. I think it is good because we don't have a case that needs them as window parameters.
There was a problem hiding this comment.
👍 That was my reasoning but I'll add them for consistency
| let room; | ||
| let recording = false; | ||
| let recordingId = ''; | ||
| const configFlags = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the way we get configuration flags in the BasicExample by creating a new global structure to hold them and parsing all of them when the window is loaded.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.