Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameterized tests for edge negotiation tests #1630

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Sep 7, 2020

Description

Add some parameterized tests for testing SDP negotiation.

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

ctx.publishAndSubscribeStreamsStep();
ctx.publishAndSubscribeStreamsStep();
ctx.publishAndSubscribeStreamsStep([
'client-add-stream',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way this is arranged. It makes it easier to read 👍

@jcague jcague merged commit 1d97c8a into lynckia:master Sep 11, 2020
@jcague jcague deleted the update/edge_negotiation_tests branch September 11, 2020 06:21
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants