Force v8 promise resolving to publish/subscriber faster #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Sep 16, 2020
| obj->futures.pop(); | ||
| obj->Unref(); | ||
| v8::Isolate::GetCurrent()->RunMicrotasks(); |
There was a problem hiding this comment.
Nice! Is this safe to use in all the places we resolve promises? I'm thinking about MediaStream particularly.
There was a problem hiding this comment.
you're right, I'm looking for all places where we use v8::Promise
| @@ -106,7 +106,7 @@ const PeerConnectionFsm = StateMachine.factory({ | |||
| }, | |||
|
|
|||
| onPendingTransition: function onPendingTransition(transition, from, to) { | |||
| const lastTransition = this.history.lenth > 0 ? this.history[this.history.length - 1].transition : 'none'; | |||
| const lastTransition = this.history.length > 0 ? this.history[this.history.length - 1].transition : 'none'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a long delay of some seconds between a promise was resolved and the corresponding listeners were triggered in ErizoAPI. This fix aims to force those triggers to complete Promise resolving quicker.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.