Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream prioritization #1682

Merged
merged 22 commits into from
Apr 13, 2021
Merged

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Feb 16, 2021

Description
This PR adds a new way to prioritize streams over others in Licode. In bw_distributor_config we can select the bw distributor, the new one being StreamPriorityBWDistributor. This new distributor will take into account stream priorities and the strategy to allocate bitrate in the connection of a subscriber

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@lodoyun lodoyun changed the title [WIP] Add stream prioritization Add stream prioritization Feb 18, 2021
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just some minor comments

@@ -196,6 +209,7 @@ class WebRtcConnection: public TransportListener, public LogContext, public Hand
std::shared_ptr<Transport> video_transport_, audio_transport_;

std::shared_ptr<Stats> stats_;
std::shared_ptr<Stats> log_stats_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

erizo/src/erizo/bandwidth/BwDistributionConfig.cpp Outdated Show resolved Hide resolved
erizo/src/erizo/bandwidth/StreamPriorityBWDistributor.cpp Outdated Show resolved Hide resolved
erizo/src/test/bandwidth/StreamPriorityBWDistributor.cpp Outdated Show resolved Hide resolved
erizo/src/test/bandwidth/StreamPriorityBWDistributor.cpp Outdated Show resolved Hide resolved
erizo_controller/erizoJS/models/Client.js Outdated Show resolved Hide resolved
lodoyun and others added 3 commits April 13, 2021 10:25
Co-authored-by: Javier Cerviño <jcague@gmail.com>
@lodoyun lodoyun merged commit c6af765 into lynckia:master Apr 13, 2021
@lodoyun lodoyun deleted the add/streamPrioritization branch April 13, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants