Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking with bzip and zlib2 when building erizo #1687

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Mar 17, 2021

Description

This PR addresses issues I experienced when linking against some boost dependencies: bzip2 and zlib.
We no longer need to use @conan/stable for things that are in the Conan Index.

Additionally, I remove the conan brew installation for mac, that is not needed anymore.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@lodoyun lodoyun changed the title Address issues when building erizo Fix linking with bzip and zlib2 when building erizo Mar 17, 2021
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun merged commit e354da8 into lynckia:master Mar 18, 2021
@lodoyun lodoyun deleted the fix/issuesWithNewConanVersion branch March 18, 2021 09:35
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants