Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QualityManager cleanup #1698

Merged
merged 1 commit into from
Apr 27, 2021
Merged

QualityManager cleanup #1698

merged 1 commit into from
Apr 27, 2021

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Apr 21, 2021

Description

Remove some old code from QualityManager that was affecting the new Stream Prioritization code:

  • QualityManager did not enable padding anymore, so I removed that code.
  • ConnectionQualityCheck will not affect QualityManager anymore. We saw weird and complex behavior due to spurious packet losses.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

lodoyun
lodoyun approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@lodoyun lodoyun merged commit 3bb99eb into lynckia:master Apr 27, 2021
@lodoyun lodoyun deleted the update/quality_manager_cleanup branch April 27, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lodoyun lodoyun lodoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcague @lodoyun