Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the way we set the stream priority in ErizoAPI #1718

Merged
merged 1 commit into from
May 31, 2021
Merged

Fix the way we set the stream priority in ErizoAPI #1718

merged 1 commit into from
May 31, 2021

Conversation

jcague
Copy link
Contributor

@jcague jcague commented May 31, 2021

Description

I introduced a bug when solving conflicts between branches. This PR should fix it.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

lodoyun
lodoyun approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! this looks good to me.
Thinks like this make me wonder if we should be thinking of other less error prone ways to do this.

@jcague jcague merged commit 39db637 into lynckia:master May 31, 2021
@jcague jcague deleted the fix/media_stream_priority branch May 31, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lodoyun lodoyun lodoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcague @lodoyun