Add packet stats and improve padding bitrate assignment #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Nov 24, 2021
| @@ -157,6 +157,8 @@ class MediaStream: public MediaSink, public MediaSource, public FeedbackSink, | |||
| bool isAudioMuted() { return audio_muted_; } | |||
| bool isVideoMuted() { return video_muted_; } | |||
|
|
|||
| bool canSendPadding() { return !isPublisher() && hasVideo() && !isVideoMuted(); } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves a potential issue when deciding which streams will send padding. The PaddingManager now filters and only assigns bitrate to those subscribed streams that have video that is not muted.
This PR also adds logs to keep track of packets received and sent per SSRC while also accounting for the video bitrate with or without padding.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.