-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a handler to control PLI sending rate #788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice! Just a naming convention thing.
erizo/src/erizo/WebRtcConnection.cpp
Outdated
@@ -29,6 +29,7 @@ | |||
#include "rtp/LayerDetectorHandler.h" | |||
#include "rtp/QualityFilterHandler.h" | |||
#include "rtp/QualityManager.h" | |||
#include "rtp/PLIPacerHandler.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using camelcase also for abbreviations lately (NackGenerator). I don't have an strong opinion on what's better but we should be consistent
std::shared_ptr<dataPacket> RtpUtils::createPLI(uint32_t source_ssrc, uint32_t sink_ssrc) { | ||
RtcpHeader pli; | ||
pli.setPacketType(RTCP_PS_Feedback_PT); | ||
pli.setBlockCount(1); | ||
pli.setBlockCount(RTCP_PLI_FMT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Here we stop sending too many PLIs when multiple clients are subscribed to one publisher. It will also send a FIR packet after waiting too long for keyframes.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc
.