Use adapter.js #940
Merged
Use adapter.js #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
reviewed
Jun 29, 2017
There was a problem hiding this comment.
This PR is really interesting!! I still need to play a little bit with it, but here I left a minor comments.
We should remove these lines in Connection.js:
} else if (that.browser === 'bowser') {
L.Logger.debug('Bowser Stack');
that = Erizo.BowserStack(spec);
| @@ -167,7 +172,7 @@ Erizo.Stream = (specInput) => { | |||
| const options = optionsInput || {}; | |||
| that.elementID = elementID; | |||
| let player; | |||
| if (that.hasVideo() || this.hasScreen()) { | |||
| if (that.hasVideo() || that.hasScreen()) { | |||
|
|
||
| that.pcConfig = { | ||
| iceServers: [], |
| } | ||
| result += 'a=x-google-flag:conference\r\n'; | ||
| return sdp.replace(matchGroup[0], result); | ||
| }; | ||
|
|
||
| const setMaxBW = (sdpInput) => { |
jcague
reviewed
Jun 29, 2017
| }; | ||
|
|
||
| that.processSignalingMessage = (msgInput) => { | ||
| // L.Logger.info("Process Signaling Message", msg); |
There was a problem hiding this comment.
Consider removing commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates most of the webrtc API calls and adds adapter.js to simplify supporting different browser.
baseStackthat is inherited by bothChromeStableStackandFirefoxStackand takes care of most of the functionality. Only small differences are now implemented in each browsers' stack.[] It needs and includes Unit Tests
Changes in Client or Server public APIs
No changes to the API
[] It includes documentation for these changes in
/doc.