New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialyzer and test fixes #29

Merged

lyokato merged 1 commit into lyokato:develop from hippware:dialyzer-fixes

Nov 12, 2018

Contributor

bernardd commented Oct 16, 2018 •

edited

Loading

This change:

Adds dialyxer as a non-runtime dependency so that dialyzer tests can easily be run (using mix dialyzer)
Fixes several incorrect types (which appear to have still worked but were causing dialyzer warnings)
Modifies the backoff period calculation slightly - in its previous form it could potentially, for example, always randomly backoff by only 1ms. That would cause a failure in the unit tests.

There's still one dialyzer warning being reported, however, that in turn is caused by a typing error down in ex_hash_ring.


          Dialyzer and test fixes

1a5cfa7

lyokato merged commit 4d5042f into lyokato:develop

Owner

lyokato commented Nov 12, 2018

Updated as 1.0.6 on hex.pm
Thanks!

bernardd deleted the dialyzer-fixes branch

November 19, 2018 00:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet