Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase resource alloc for blackbox exporter #159

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Dec 21, 2017

This change addresses a performance regression in the blackbox exporter.

We believe that the issue is due to the Go GC as originally reported in prometheus/blackbox_exporter#270

It may be that one day the Go compiler will fix the inefficiency but until then, we can simply provide more resources.


This change is Reviewable

@nkinkade
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@stephen-soltesz stephen-soltesz merged commit 7f8c417 into master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants