Remove xbuild and use build-std feature #1787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 24, 2021 16:43
Signed-off-by: Steve Fan <sf@m-labs.hk>
Signed-off-by: Steve Fan <sf@m-labs.hk>
Signed-off-by: Steve Fan <sf@m-labs.hk>
stevefan1999
force-pushed
the
patch-no-xbuild
branch
from
640ebcb
to
359aa17
Compare
|
Nix enforced to require vendored source. This is blocked by rust-lang/wg-cargo-std-aware#23, otherwise we have to specify each and every dependencies in any of the lock files for them to be vendored-in. Closing this right now as it is not very feasible to find any missing dependencies or until that particular issue is fixed. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIQ Pull Request
Description of Changes
This is a simple PR that removes the need for cargo xbuild, and introduces to use
build-stdthat existed since nightly 2020–07–15. In fact, the developer of xbuild also suggested using the build-std feature instead. The only downside of this is a nightly version of Rust is required.Type of Changes
It also logically reverts some of the series of changes in dcbd9f9