Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nibs with spaces in the name will generate invalid code #56

Closed
2 tasks done
mac-cain13 opened this issue Aug 8, 2015 · 2 comments
Closed
2 tasks done

Nibs with spaces in the name will generate invalid code #56

mac-cain13 opened this issue Aug 8, 2015 · 2 comments
Labels
difficulty: easy state: confirmed type: issue

Comments

@mac-cain13
Copy link
Owner

As reported by @tomekc in PR #52, nibs that have spaces in their name will generated invalid code.

We should:

  • Write test confirming this issue
  • Fix the issue
mac-cain13 added a commit that referenced this issue Aug 8, 2015
@mac-cain13
Add integration test for issue #56
a13b3eb
mac-cain13 added a commit that referenced this issue Aug 8, 2015
@mac-cain13
Sanitize nib struct name
f08d67f 
This fixes issue #56 where invalid code was generated.
@mac-cain13
Copy link
Owner Author

Fixed on develop, will be in next release.

mac-cain13 added a commit that referenced this issue Aug 8, 2015
@mac-cain13
Sanitize nib struct name
5014c6d 
This fixes issue #56 where invalid code was generated.
@mac-cain13
Copy link
Owner Author

Also fixed in 0.8.5 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy state: confirmed type: issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mac-cain13