Skip to content

Commit

Permalink
Reverting incorrect code move (openhab#16548)
Browse files Browse the repository at this point in the history
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
  • Loading branch information
clinique authored and magx2 committed Mar 24, 2024
1 parent fab7483 commit 77cb63c
Showing 1 changed file with 10 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import java.util.stream.Collectors;

import org.eclipse.jdt.annotation.NonNullByDefault;
import org.eclipse.jdt.annotation.Nullable;
import org.openhab.binding.netatmo.internal.api.HomeApi;
import org.openhab.binding.netatmo.internal.api.NetatmoException;
import org.openhab.binding.netatmo.internal.api.data.NetatmoConstants.FeatureArea;
Expand Down Expand Up @@ -66,12 +65,6 @@ public void initialize() {
if (!config.securityId.isBlank()) {
homeIds.add(config.securityId);
}
if (hasArea(FeatureArea.SECURITY) && !handler.getCapabilities().containsKey(SecurityCapability.class)) {
handler.getCapabilities().put(new SecurityCapability(handler));
}
if (hasArea(FeatureArea.ENERGY) && !handler.getCapabilities().containsKey(EnergyCapability.class)) {
handler.getCapabilities().put(new EnergyCapability(handler, descriptionProvider));
}
}

@Override
Expand All @@ -83,6 +76,16 @@ public void dispose() {
@Override
protected void updateHomeData(HomeData home) {
if (firstLaunch) {
if (featureAreas.contains(FeatureArea.SECURITY)) {
handler.getCapabilities().put(new SecurityCapability(handler));
} else {
handler.removeChannels(thing.getChannelsOfGroup(GROUP_SECURITY));
}
if (featureAreas.contains(FeatureArea.ENERGY)) {
handler.getCapabilities().put(new EnergyCapability(handler, descriptionProvider));
} else {
handler.removeChannels(thing.getChannelsOfGroup(GROUP_ENERGY));
}
home.getCountry().map(country -> properties.put(PROPERTY_COUNTRY, country));
home.getTimezone().map(tz -> properties.put(PROPERTY_TIMEZONE, tz));
properties.put(GROUP_LOCATION, ((Location) home).getLocation().toString());
Expand All @@ -91,21 +94,6 @@ protected void updateHomeData(HomeData home) {
}
}

@Override
protected void afterNewData(@Nullable NAObject newData) {
if (firstLaunch && !hasArea(FeatureArea.SECURITY)) {
handler.removeChannels(thing.getChannelsOfGroup(GROUP_SECURITY));
}
if (firstLaunch && !hasArea(FeatureArea.ENERGY)) {
handler.removeChannels(thing.getChannelsOfGroup(GROUP_ENERGY));
}
super.afterNewData(newData);
}

private boolean hasArea(FeatureArea searched) {
return featureAreas.contains(searched);
}

/**
* Errored equipments are reported at home level - so we need to explore all the tree to identify modules
* depending from a child device.
Expand Down

0 comments on commit 77cb63c

Please sign in to comment.