Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui overhaul #2

Merged
merged 6 commits into from
Feb 12, 2015
Merged

Ui overhaul #2

merged 6 commits into from
Feb 12, 2015

Conversation

omegahm
Copy link
Contributor

@omegahm omegahm commented Feb 11, 2015

I gave the UI a general overhaul. Hope you guys like it.

This pull-request includes features such as:

  • Introduced CSS file
  • Decluttered CSS and HTML
  • Moved scripts to bottom of page
  • Use logo as favicon
  • Use Bootstraps classes
  • Got rid of Bootstrap theme

"Front page"

screen shot 2015-02-11 at 22 23 48

and with Jim active

screen shot 2015-02-11 at 22 24 50

HTML mail

screen shot 2015-02-11 at 22 23 44

Modal

screen shot 2015-02-11 at 22 24 01

@omegahm
Copy link
Contributor Author

omegahm commented Feb 11, 2015

I couldn't figure out if I was meant to commit the assets/assets.go-file as well, so I left that one out.

The reason I couldn't figure out if I should have committed it, was that there was changes to it, the first time I booted the application, with no changes elsewhere.

@ian-kent
Copy link
Member

That looks awesome, thanks @omegahm

Sorry I haven't had time to look properly yet - I'll try and get it merged and a release out tonight!

Thanks 😄

@ian-kent
Copy link
Member

(p.s., assets.go should be included since it enables go get commands to work, but no prob, it'll get rebuilt when I publish a release anyway 🐼)

@omegahm
Copy link
Contributor Author

omegahm commented Feb 12, 2015

I'll add the assets.go to this pull-request once I get home 👍

ian-kent added a commit that referenced this pull request Feb 12, 2015
@ian-kent ian-kent merged commit eb8c2f3 into mailhog:master Feb 12, 2015
@ian-kent
Copy link
Member

Awesome, thank you!!!! Looks much cleaner 👍

@thaJeztah
Copy link

Oh, wow, merged already!

Awesome job, @omegahm!

@omegahm
Copy link
Contributor Author

omegahm commented Feb 12, 2015

You are very welcome. We just started using MailHog (as oppose to Mailcatcher) in our integration tests. Love the API and love the "quickness" that comes with Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants