replace all occurrences of the same CID reference #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the incorrect behaviour of only replacing the _first_ instance of a CID reference by using a regular expression with a global flag. Example: referencing the same inline-attachment in multiple places within the same email (often used for responsive HTML emails)
|
@jerbob92 you're correct, I didn't notice that. Either PR will work, would love to get one of them merged! |
|
@jerbob92 I'll have a look asap, should have some time this weekend! |
Closed
|
Thanks! |
|
@ian-kent I don't think your 1.0.0 release was built using HEAD from this repo - the old UI code is still shipping with that release (checked binary output). |
|
@ian-kent any chance of a re-release of this? doesn't seem to be in the latest package |
ayumi-
pushed a commit
to ayumi-/MailHog-UI
that referenced
this pull request
Dec 8, 2018
replace all occurrences of the same CID reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the incorrect behaviour of only replacing the first instance of a CID reference by using a regular expression with a global flag.
Example: referencing the same inline-attachment in multiple places within the same email (often used for responsive HTML emails)