Base Token Bridge #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldchili
reviewed
Jul 14, 2024
oldchili
reviewed
Jul 14, 2024
oldchili
reviewed
Jul 15, 2024
oldchili
reviewed
Jul 15, 2024
| /// @param _extraData Extra data to be sent with the transaction. Note that the recipient will | ||
| /// not be triggered with this data, but it will be emitted and can be used | ||
| /// to identify the transaction. | ||
| function bridgeERC20( |
There was a problem hiding this comment.
I see we define different interfaces on the dai bridge, for example - https://github.com/makerdao/optimism-dai-bridge/blob/master/contracts/l1/L1DAITokenBridge.sol#L102
This was a design decision right?
The standard bridge interface was as it is now at the time?
There was a problem hiding this comment.
This is the new interface. The dai bridge was using the old interface, pre-bedrock. We might need to also support the old interface as the standard bridge does, but not 100% sure yet, so for now I've only included the methods for the new interface.
oldchili
reviewed
Jul 22, 2024
added 9 commits
July 22, 2024 12:05
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
Co-authored-by: sunbreak1211 <129470872+sunbreak1211@users.noreply.github.com>
sunbreak1211
approved these changes
Aug 21, 2024
oldchili
reviewed
Aug 21, 2024
oldchili
reviewed
Aug 21, 2024
sunbreak1211
approved these changes
Aug 21, 2024
oldchili
approved these changes
Aug 21, 2024
sunbreak1211
approved these changes
Aug 23, 2024
oldchili
approved these changes
Aug 25, 2024
Co-authored-by: telome <>
* Add Cantina Report * Rename Cantina report --------- Co-authored-by: telome <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.