Fix broken make test-forge match="<test>"
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--match` flag was finally removed from `forge` in favor of `--match-test`/`--match-contract`/`--match-path`. This script is now broken.
amusingaxl
requested review from
0xdecr1pto,
SidestreamSweatyPumpkin and
SidestreamColdMelon
SidestreamColdMelon
approved these changes
Jun 21, 2023
0xdecr1pto
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--matchflag was finally removed fromforgein favor of--match-test/--match-contract/--match-path.This script is now broken when trying to use that feature.
This fix has already been merged on Goerli (see spells-goerli#205).
[Fixes #350]