Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cast-on-tenderly script #388

Merged
merged 10 commits into from
Feb 12, 2024
Merged

Conversation

SidestreamColdMelon
Copy link
Contributor

@SidestreamColdMelon SidestreamColdMelon commented Jan 30, 2024

Closes #389

This PR updates cast-on-tenderly script to:

  • Update cast-on-tenderly outdated dependencies
  • Update logic of the script to better calculate nextCastDate (and account for "office hours")
  • Work with Tenderly Testnets instead of Forks

@SidestreamColdMelon SidestreamColdMelon marked this pull request as ready for review February 8, 2024 10:36
@SidestreamColdMelon
Copy link
Contributor Author

The updated script is ready for review and can be tested with the last spell address via make cast-on-tenderly spell=0x0E9AB92e3Fad77eE35a5f702Ac56c48bAAB7B0eE. Note: please make sure to afterwards delete newly created testnet (via their UI, in the testnet settings)

scripts/cast-on-tenderly/index.js Outdated Show resolved Hide resolved
scripts/cast-on-tenderly/index.js Outdated Show resolved Hide resolved
scripts/cast-on-tenderly/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@amusingaxl amusingaxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits regarding naming for discussion, but I'm not feeling that strong about it. Feel free to keep it as it is.
At this point, it becomes a bit subjective unless we have some fairly comprehensive style guide in place, which we don't.

scripts/cast-on-tenderly/index.js Outdated Show resolved Hide resolved
scripts/cast-on-tenderly/index.js Show resolved Hide resolved
scripts/cast-on-tenderly/index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cast-tenderly script
3 participants