Mainnet spell 2024-08-22

[oddaf]

Description

Contribution Checklist

• PR title starts with (PE-<TICKET_NUMBER>)
• Code approved
• Tests approved
• CI Tests pass

Checklist

• Every contract variable/method declared as public/external private/internal
• Consider if this PR needs the officeHours modifier override
• Verify expiration (30 days unless otherwise specified)
• Verify hash in the description matches here
• Validate all addresses used are in changelog or known
• Notify any external teams affected by the spell so they have the opportunity to review
• Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• Verify mainnet contract on etherscan
• Change test to use mainnet spell address and deploy timestamp
• Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• squash and merge this PR

[amusingaxl]

Not a reviewer, but I found a couple of nits.

[SidestreamColdMelon]

TLDR: Good to deploy

Development Stage

• Preparation
  • Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet
    Insert URL to the specific sheet here
    https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit?gid=175785542#gid=175785542
  • Using Exec Sheet URL from the above, read spell instructions from the Exec Sheet and list them below
    List all instructions announced in the Exec Sheet
    • Repeating Checklist Item
      • Office Hours Yes
      • Global Line Modifier No
      • Order of Operations Issues No
    • Update PSM state variable in the conduit contracts to MCD_LITE_PSM_USDC_A
      • RWA014_A_INPUT_CONDUIT_URN
      • RWA014_A_INPUT_CONDUIT_JAR
      • RWA014_A_OUTPUT_CONDUIT
      • RWA007_A_JAR_INPUT_CONDUIT
      • RWA007_A_INPUT_CONDUIT
      • RWA007_A_OUTPUT_CONDUIT
      • RWA015_A_INPUT_CONDUIT_JAR_USDC
      • RWA015_A_INPUT_CONDUIT_URN_USDC
      • RWA015_A_OUTPUT_CONDUIT
      • RWA009_A_INPUT_CONDUIT_URN_USDC
    • Phase 2 USDC Migration from PSM-USDC-A to LITE-PSM-USDC-A
      • Migrate all but 200 million USDC reserves from PSM-USDC-A to LITE-PSM-USDC-A
    • Update PSM-USDC-A Fees
      • PSM-USDC-A tin: Increase by 0.01 percentage points, from 0% to 0.01%
      • PSM-USDC-A tout: Increase by 0.01 percentage points, from 0% to 0.01%
    • Update PSM-USDC-A DC-IAM
      • PSM-USDC-A DC-IAM DC-IAM line: Decrease by 7,500 million DAI, from 10,000 million DAI to 2,500 million DAI.
      • PSM-USDC-A DC-IAM DC-IAM gap: Decrease by 180 million DAI, from 380 million DAI to 200 million DAI.
      • PSM-USDC-A DC-IAM DC-IAM ttl: 12h (Unchanged)
    • Update MCD_LITE_PSM_USDC_A Buf
      • MCD_LITE_PSM_USDC_A buf: Increase by 180 million DAI, from 20 million DAI to 200 million DAI
    • Update LITE-PSM-USDC-A DC-IAM
      • LITE-PSM-USDC-A DC-IAM line: Increase by 7,450 million DAI, from 50 million DAI to 7,500 million DAI.
      • LITE-PSM-USDC-A DC-IAM gap: Increase by 180 million DAI, from 20 million DAI to 200 million DAI.
      • LITE-PSM-USDC-A DC-IAM ttl: 12h (Unchanged)
    • GSM Delay Update
      • Increase the GSM Pause Delay by 14h, from 16h to 30h
    • Update LitePSM Keeper Network Job
      • Remove the old LitePSMJob (0x689cE517a4DfCf0C5eC466F2757D324fc292C8Be) from the CronSequencer
      • Add the new LitePSMJob (0x0c86162ba3e507592fc8282b07cf18c7f902c401) to the Cron Sequencer
      • fill: Set the rushThreshold to 20 million DAI
      • trim: Set the gushThreshold to 20 million DAI
      • chug: Set the cutThreshold to 300,000 DAI (Unchanged)
      • Update CRON_LITE_PSM_JOB to 0x0c86162ba3e507592fc8282b07cf18c7f902c401 in the Chainlog
• Base checks
  • Current solc version 0.8.16
  • Office hours is true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
  • Office hours value matches the Exec Sheet
  • 30 days spell expiry set in the constructor (block.timestamp + 30 days)
• Spell description
  • Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
  • TARGET_DATE in the description matches the target date
  • Accompanying comment above spell description follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
• Comments inside the spell
  • Every Section text from the Exec Sheet is copied to the spell code as a comment surrounded by the set of dashes (E.g. // ----- Section text -----)
  • Every Instruction text from the Exec Sheet is copied to the spell code as // Instruction text
  • Every Instruction text have newline above it
    ⚠️ This is not always followed, but is a good compromize for readability
  • IF an instruction can not be taken, it should have explanation under the instruction prefixed with // Note: (e.g.: // Note: Payments are skipped on goerli)
  • IF action in the spell doesn't have relevant instruction (e.g.: chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL have prefix derived from the url itself
    • // Executive Vote: if URL starts with https://vote.makerdao.com/executive/
    • // Poll: if URL starts with https://vote.makerdao.com/polling/
    • // Forum: if URL starts with https://forum.makerdao.com/t/
    • // MIP: if URL starts with https://mips.makerdao.com/mips/details/
• Dependency checks
  • Update Foundry by running foundryup
    ℹ️ Updated versions:

    foundryup: installed - forge 0.2.0 (afd8680 2024-08-21T00:19:11.446603000Z)
    foundryup: installed - cast 0.2.0 (afd8680 2024-08-21T00:19:11.469127000Z)
    foundryup: installed - anvil 0.2.0 (afd8680 2024-08-21T00:19:11.430428000Z)
    foundryup: installed - chisel 0.2.0 (afd8680 2024-08-21T00:19:11.420822000Z)
    

  • Reinstall libraries by running rm -rf ./lib && git submodule update --init --recursive

    Insert checked out submodule paths here
    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'

  • IF submodule upgrades are present, make sure dss-exec-lib is synced as well
  • git submodule hash of dss-exec-lib (run git submodule status) matches the latest release version or newer
  • dss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-test
• IF interfaces are present in the spell
  • Interfaces imported from dss-interfaces
    • No unused dss-interfaces
    • Only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)
  • Static Interfaces
    • No unused static interfaces
    • Declared static interface not present in the dss-interfaces, OTHERWISE should be imported from there
      ⚠️ PauseLike is present as DSPauseAbstract, but contains more methods that will be unused in this spell, so it's acceptable to re-declare the interface also by the previous convention
    • Interface matches deployed contract using cast interface <contract_address> command
    • Interface naming style should match with Like suffix (e.g. VatLike)
      • EXCEPTION: known interface naming exceptions
    • Each static interface declare only functions actually used in the spell code
• IF variable declarations are present in the spell
  • IF precision units are present
    • Precision units used in the spell match their defined values:
      • WAD = 10 ** 18
      • RAY = 10 ** 27
      • RAD = 10 ** 45
    • Precision units match with Numerical Ranges
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
  • IF math units are present
    • Match their defined values:
      • HUNDRED = 10 ** 2
      • THOUSAND = 10 ** 3
      • MILLION = 10 ** 6
      • BILLION = 10 ** 9
    • Match with config
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
  • IF rates are present
    • Rates match generated locally via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Rates match IPFS document
    • Rate variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)
    • Rate variable visibility declared as internal
    • Rate variable state mutability declared as constant
  • IF timestamps are present
    • Comment above timestamp states full date including UTC timezone
    • Timestamp converts back to the correct date
    • Timestamp converts back to the UTC timezone
    • Variable naming matches MMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)
    • Time of day makes logical sense in the context of timestamp usage (i.e. 23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
• IF new contract is present in the spell (not yet on chainlog or new to chainlog)
  • CRON_LITE_PSM_JOB_NEW deployed to 0x0C86162ba3E507592fC8282b07cF18c7F902C401, with source code found in makerdao/dss-cron
    • Source code is verified on etherscan
    • Compilation optimizations match deployment settings defined in the source code repo
      ℹ️ Found here
    • GNU AGPLv3 license
    • Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
      ℹ️
      • _sequencer (address): 0x238b4E35dAed6100C6162fAE4510261f88996EC9
        • Matches CRON_SEQUENCER in the chainlog
      • _litePsm (address): 0xf6e72Db5454dd049d0788e411b06CfAF16853042
        • Matches MCD_LITE_PSM_USDC_A in the chainlog
      • _rushThreshold (uint256): 20_000_000_000000000000000000
        • Matches Exec Sheet
      • _cutThreshold (uint256): 300_000_000000000000000000
        • Matches Exec Sheet
      • _gushThreshold (uint256): 20_000_000_000000000000000000
        • Matches Exec Sheet
    • IF new contract have concept of wards or access control
      • Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
      • Ensure that contract deployer address was denied (wards(deployer) is 0)
      • Ensure MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)
      • Ensure that there are no other Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)
    • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
    • Deployer address is included into addresses_deployers.sol
• IF core system parameter changes are present in the instructions
  ℹ️ Although not present in the list below, MCD_PAUSE.delay is updated via PauseLike(MCD_PAUSE).setDelay (as no relevant method is found in DssExecLib)
  • IF stability fee (jug.ilk.duty) is updated
    • (DssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used
    • Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
  • IF Dai Savings Rate (pot.dsr) is updated
    • (DssExecLib.setDSR(rate, doDrip)) is used
    • Comment matches pattern // Increase DSR by X.XX% from X.XX% to X.XX%
    • Double check that rate match make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Double check that rate match IPFS document
  • IF spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is used
  • IF dog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is used
  • IF vat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is used
  • IF dog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is used
  • IF clip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is used
  • IF clipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is used
  • IF clip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is used
  • IF clip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is used
  • IF clip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is used
  • IF clip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is used
  • IF calc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is used
  • IF calc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is used
• IF debt ceiling changes are present in the instructions
  • IF adjusted collateral type (ilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)
    • IF collateral debt ceiling requested to be 0
      • Collateral is removed from AutoLine (MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)
      • The instruction to remove from AutoLine (MCD_IAM_AUTO_LINE) is present in the Exec Sheet
      • Collateral debt ceiling is set to 0 via DssExecLib.setIlkDebtCeiling(ilk, amount)
      • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to
    • IF AutoLine parameters are updated
      • EITHER is used, depending on the instruction:
        ⚠️ Altrough two relevant instructions are present (Update LITE-PSM-USDC-A DC-IAM and Update PSM-USDC-A DC-IAM), they are performed by the DssLitePsmMigrationPhase2 library using low-level call autoLine.setIlk. That is not a problem, since the library was audited and unit checks (found in setIlkAutoLineParameters) were performed manually
        • DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
        • DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
  • IF collateral debt ceiling (vat.ilk.line) is updated
    • Collateral type (ilk) have AutoLine disabled previously or in the spell
    • EITHER is used, depending on the instruction:
      • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.setIlkDebtCeiling(ilk, amount)
    • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
      • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
      • DssExecLib.setGlobalDebtCeiling(amount)
      • DssExecLib.increaseGlobalDebtCeiling(amount)
      • DssExecLib.decreaseGlobalDebtCeiling(amount)
• IF additional dependencies (i.e. ./src/dependencies/ directory) are present:
  • IF the dependencies contracts/libraries have been audited
    ℹ️ Audit could be found at chainsecurity.com although the PDF itself is uploaded to a CDN. Latest commit hash mentioned there is 2f11f4bc47d96f4ebf025a1e4a249987150f9baa
    • Each contract/library exactly matches (i.e. diff check) the source code of the latest audited version
      • src/dependencies/dss-lite-psm/phase-2/DssLitePsmMigrationPhase2.sol matches audited source code found at https://github.com/makerdao/dss-lite-psm/blob/2f11f4bc47d96f4ebf025a1e4a249987150f9baa/src/deployment/phase-2/DssLitePsmMigrationPhase2.sol
      • src/dependencies/dss-lite-psm/DssLitePsmMigration.sol matches audited source code found at https://github.com/makerdao/dss-lite-psm/blob/2f11f4bc47d96f4ebf025a1e4a249987150f9baa/src/deployment/DssLitePsmMigration.sol
  • OTHERWISE obtain the permalink to the relevant repository from a trusted party (i.e. Gov Facilitators)
    • Each contract/library exactly matches (i.e. diff check) the source code from the permalink
• IF onboarding is present
  • Insert and follow the relevant checklists below:
    • Collateral Onboarding
    • RWA Onboarding
    • Teleport Onboarding
• IF PSM migration, onboarding or offboarding is present:
  • Insert and follow the relevant checklists below:

    • PSM Checklists

      PSM Checklists

      PSM Migration Checklist

      • IF LitePSM MOM is being on-boarded in the current spell, execute the full LitePSM MOM Onboarding Checklist
      • IF LitePSM contracts are being on-boarded in the current spell, execute the full LitePSM Onboarding Checklist
      • IF a PSM is deprecated in the migration, execute the full PSM Offboarding Checklist
      • IF present, max amount of gems to move (dstWant) matches the Exec Sheet
      • IF present, min amount of gems to keep (srcKeep) matches the Exec Sheet
      • Source PSM:
        • ilk matches source PSM
        • IF present, tin matches the value in the Exec Sheet
        • IF present, tout matches the value in the Exec Sheet
        • AutoLine is updated according to the Exec Sheet
      • Destination PSM:
        • ilk matches destination PSM
        • IF present, tin matches the value in the Exec Sheet
        • IF present, tout matches the value in the Exec Sheet
        • AutoLine is updated according to the Exec Sheet
        • buf matches the value in the Exec Sheet
        • fill is called conditionally (if(rush() > 0)) to ensure liquidity is immediately available after spell execution
      • Test coverage:
        • Collateral amount that is fetched from the source PSM matches the collateral is added to the destination PSM
          • vat.urns(DST_ILK, dstPsm).art is increased at least by the moved amount
          • gem balance of dstPocket is increased exactly by the moved amount
          • Dai balance of dstPsm is equal to dstBuf, UNLESS limited by the debt ceiling (line)
          • vat.urns(SRC_ILK, srcPsm).art is decreased exactly by the moved amount
          • vat.urns(SRC_ILK, srcPsm).ink is decreased exactly by the moved amount
          • gem balance of srcPsm.gemJoin() is decreased exactly by the moved amount
        • No bad debt is left behind
          • vat.vice() is unchanged after the spell execution
          • vat.sin(MCD_PAUSE_PROXY) is unchanged after the spell execution

      LitePSM Onboarding Checklist

      • Deployed Contracts
        • DssLitePsm ℹ️ Not onboarded in this spell
          • Optimizer is enabled
          • Optimize runs is set to 200
          • Contract has been reviewed by minimum 2 specialized Active Ecosystem Actors
          • Contract has been audited by an external party
            • Audit report source could be confirmed (i.e. found on auditor's website)
            • All issues found were fixed or acknowledged
            • No code changes are done after final audit report, based on the commit hash found in the report +
              • EITHER code diff check for each individual file
              • OR bytecode verification tool such as forge verify-bytecode
          • Deployed contract matches the code in the repo
          • Constructor params:
            • ilk is named LITE-PSM-{TOKEN_SYMBOL}-A (i.e. LITE-PSM-USDC-A)
            • gem matches the expected token address
            • daiJoin matches MCD_JOIN_DAI from the chainlog
            • pocket matches the pocket address in the Exec Sheet
          • Deployer no longer has privileged access (wards(deployer) == 0)
          • MCD_PAUSE_PROXY has been authed (i.e. require(WardsLike({LITE_PSM}).wards(MCD_PAUSE_PROXY) == 1))
          • Sanity check: DssLitePsm has type(uint256).max approval to spend gem on behalf of pocket
        • LitePsmJob ℹ️ deployed to 0x0C86162ba3E507592fC8282b07cF18c7F902C401
          • Uses the default Solidity version in dss-cron
          • Optimizer is enabled
          • Deployed contract matches the code in the repo
          • Constructor params:
            • _sequencer matches CRON_SEQUENCER address from the chainlog
            • _litePsm matches {LITE_PSM} address
            • _rushThreshold matches the Exec Sheet (it might be named as "fill threshold")
            • _gushThreshold matches the Exec Sheet (it might be named as "trim threshold")
            • _cutThreshold matches the Exec Sheet (it might be named as "chug threshold")
      • Initialization ℹ️ Nothing is initialised in this spell
        • DssLitePsm:
          • buf is set to the value specified in the Exec Sheet
          • vow is set to MCD_VOW from the chainlog
          • MCD_PAUSE_PROXY is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).kiss(MCD_PAUSE_PROXY))
          • DssLitePsmMom is authed (i.e. RelyLike({LITE_PSM}).rely(MOM))
        • LitePsmJob:
          • Job is added to CRON_SEQUENCER
        • MCD_VAT:
          • New ilk is initialized
        • MCD_JUG:
          • New ilk is initialized
        • MCD_SPOT:
          • Sanity check: Dai parity (par) current value is 1 (1 * RAY)
          • Collateralization ratio (mat) is set to 100% (1 * RAY) for the ilk
          • IF a new pip is being used:
            • pip is set for the ilk
            • pip is a DSValue instance
            • The value on pip is set to 1 (1 * WAD)
            • pip deployer is no longer the owner
            • MCD_PAUSE_PROXY is the owner on pip
          • OTHERWISE when reusing an existing pip:
            • pip is set for the ilk
            • pip in the chainlog matches gem symbol (i.e. PIP_USDC for USDC)
        • ILK_REGISTRY:
          • New ilk is added to the registry
        • CHAINLOG:
          • DssLitePsm is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
          • pocket is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
          • DssLitePsmMom is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
          • LitePsmJob is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
          • IF a new pip is being added, it is added to the chainlog and addresses_mainnet.sol as PIP_{TOKEN_SYMBOL} (i.e. PIP_USDC)
      • Test coverage:
        • DssLitePsm: ℹ️ Tested via testLitePSMs
          • vow is set to MCD_VOW
          • buf matches the Exec Sheet
          • MCD_PAUSE_PROXY is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).bud(MCD_PAUSE_PROXY) == 1)
          • DssLitePsmMom is authed (i.e. WardsLike({LITE_PSM}).wards(MOM) == 1)~~
          • E2E tests:
            • buyGem works as expected
            • sellGem works as expected
            • buyGemNoFee works as expected
            • sellGemNoFee works as expected
        • DssLitePsmMom: ℹ️ Tested via testLitePSMs
          • E2E tests:
            • halt prevents new swaps in {LITE_PSM}
        • LitePsmJob: ℹ️ Tested via test_CRON_LITE_PSM_JOB
          • Job is added to CRON_SEQUENCER (i.e.: SequencerLike(CRON_SEQUENCER).hasJob(LITE_PSM_JOB) == true)
          • sequencer matches CRON_SEQUENCER address from the chainlog
          • litePsm matches {LITE_PSM} address
          • rushThreshold matches the Exec Sheet (it might be named as "fill threshold")
          • gushThreshold matches the Exec Sheet (it might be named as "trim threshold")
          • cutThreshold matches the Exec Sheet (it might be named as "chug threshold")
          • E2E tests:
            • work has the desired effect:
              • IF rush() > _rushThreshold, fill is called
              • OTHERWISE IF cut() > _cutThreshold, chug is called
              • OTHERWISE IF gush() > _gushThreshold, trim is called
              • OTHERWISE it reverts
        • MCD_VAT: ℹ️ Tested via testLitePSMs
          • urns[ilk][{LITE_PSM}].ink is set to the max value that will not cause an overflow (int256(type(uint256).max / RAY))
        • MCD_JUG: ℹ️ Tested via testGeneral
          • Stability fee (duty) is set to 0% (1 * RAY) for the ilk (:information_source: covered in config.sol)
        • MCD_SPOT: ℹ️ Tested via testGeneral
          • spotter(DST_ILK).mat is set to 100% (1 * RAY) (:information_source: covered in config.sol)
          • spotter(DST_ILK).pip is set correctly
        • CHAINLOG: ℹ️ It is indeed bumped, but for another reason
          • Version is bumped: {x}.{y}.{z+1} (:information_source: covered in config.sol)
        • ILK_REGISTRY: ℹ️ Tested via testLitePSMs
          • New ilk is added to the registry
          • name matches gem name
          • symbol matches gem symbol
          • class for join-less ilks is used (REG_CLASS = 6)
          • gem matches the configured gem
          • pip matches the configured pip
          • gemJoin is set to address(0)
          • clip is set to address(0)
• IF collateral offboarding is present in the spell
  • 1st stage collateral offboarding
    • Collateral type (ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabled
    • Collateral debt ceiling (vat.ilk.line) is set to 0
    • Global debt ceiling (vat.Line) decreased by the total amount of offboarded ilks
  • 2nd stage collateral offboarding
    • All actions from the 1st stage offboarding are previously taken (EITHER in the current or past spells – check the archive)
    • Collateral liquidation penalty (chop) is set to 0 IF requested by governance
    • Flat keeper incentive (tip) is set to 0 IF requested by governance
    • Relative keeper incentive (chip) is set to 0 IF requested by governance
    • Max liquidation amount (hole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governance
    • Relevant clipper contract (MCD_CLIP_) is active (i.e. stopped is 0)
    • Liquidations are triggered via (depending on governance instruction):
      • EITHER liquidation ratio (spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))
      • OR via enabling linear interpolation (DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))
        • Ensure name format matches "XXX-X Offboarding"
        • Ensure target matches DssExecLib.spotter() address
        • Ensure ilk format matches collateral type (ilk) name ("XXX-X")
        • Ensure what matches string "mat"
        • Ensure startTime matches block.timestamp
        • Ensure start uses variable CURRENT_XXX_A_MAT
        • Ensure start matches current spotter.ilk.mat value
        • Ensure end uses variable TARGET_XXX_A_MAT
        • Ensure end value matches the instruction
        • Ensure end allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)
        • Ensure duration matches the instruction
    • Spotter price is updated via DssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)
    • Spotter price is updated after all other actions
    • Offboarding is tested at least via _checkIlkClipper helper
• IF RWA updates are present
  ℹ️ Although not present in the list below, we're updating PSM address for multiple RWA input and output conduits, as requested by the governance. This is therefore done using either DssExecLib.setContract (for regular conduits) or using low-level slap+clap (for the MultiSwap conduit)
  • IF doc is updated
    • _updateDoc helper is copied one-to-one from the archive and defined above actions
    • _updateDoc(ilk, doc) is called in the spell
  • IF debt ceiling is updated
    • IF AutoLine update is requested by the Exec Sheet
      • Parameters are set via DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
    • IF regular debt ceiling (vat.ilk.line) update is requested by the Exec Sheet
      • Collateral type (ilk) have AutoLine disabled previously or in the spell
      • Debt ceiling (vat.ilk.line) is updated, via EITHER:
        • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
        • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
        • DssExecLib.setIlkDebtCeiling(ilk, amount)
      • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
        • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
        • DssExecLib.setGlobalDebtCeiling(amount)
        • DssExecLib.increaseGlobalDebtCeiling(amount)
        • DssExecLib.decreaseGlobalDebtCeiling(amount)
    • Liquidation oracle price is bumped via RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) pattern
      • Comment above bump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"
      • Comment above bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)
        • The formula matches the example provided above
        • debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLine
        • rwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chain
        • minimum_deal_duration_in_years in the executable formula matches number found in the Exec Sheet of the spell containing relevant RWA onboarding
        • liquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chain
        • Executing formula locally provides integer number that matches the val in the spell
      • val makes sense in context of the rate mechanism
    • IF multiple RWA ilks are being combined into one, val calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal
    • Oracle price is updated via DssExecLib.updateCollateralPrice(ilk)
    • IF soft liquidation explicitly requested to be triggered (via .tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)
      • RwaLiquidationOracle.tell(ilk) call is present
      • IF RWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)
• IF payments are present in the spell
  • IF MKR transfers are present
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • Transfer amount is specified with (at least) 2 decimals using ether keyword
    • IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
    • The transfers are tested via testMKRPayments test
    • Sum of all MKR transfers tested in testMKRPayments matches number in the Exec Sheet
  • IF DAI surplus buffer transfers are present
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • The transfers are tested via testDAIPayments test
    • Sum of all DAI transfers tested in testDAIPayments matches number in the Exec Sheet
  • IF MKR or DAI streams (DssVest) are created
    • VestAbstract interface is imported from dss-interfaces/dss/VestAbstract.sol
    • restrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Sheet
    • usr (Vest recipient address) matches Exec Sheet
    • usr address in the instruction is in the checksummed format
    • usr address variable name match one found in addresses_wallets.sol
    • tot (Total stream amount) matches Exec Sheet
    • IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
    • IF vest amount is expressed in 'per year' or similar in the Exec Sheet, account for leap days
    • bgn (Vest start timestamp) matches Exec Sheet
    • tau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • fin (Vest end timestamp) matches Exec Sheet
    • eta (Vest cliff duration) matches the following logic
      • IF eta is explicitly specified in the Exec Sheet, then the values match
      • IF eta and clf (Cliff end timestamp) are not specified in the Exec Sheet, then eta is 0
      • IF clf is specified, but clf <= bgn, then eta is 0
      • IF clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • IF mgr (Vest manager address) is specified in the Exec Sheet, matches the value, OTHERWISE matches address(0)
    • Ensure that max vesting rate (cap) is enough for the new streams
      • The maximum vesting rate (tot divided by tau) <= the maximum vest streaming rate (cap)
      • The maximum vesting rate (tot divided by tau) > the maximum vest streaming rate (cap)
      • Calculate new cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)
    • IF max vesting rate (cap) is changed in the spell
      • Governance facilitators were notified
      • Exec Sheet contain explicit instruction
      • Exec Sheet contain explicit instruction
    • IF MKR stream (DssVestTransferrable) is present
      • Vest contract's MKR allowance increased by the cumulative total (the sum of all tot values)
      • Ensure allowance increase follows archive patterns
    • Tested via testVestDAI or testVestMKR
  • IF MKR or DAI vest termination (Yank) is present
    • Yanked stream ID matches Exec Sheet
    • MCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yank
    • MCD_VEST_DAI chainlog address is used for DAI stream yank
    • Tested via testYankDAI or testYankMKR
• IF SubDAO-related content is present
  • IF SubDAO provides SubProxy spell address
    • SubDAO spell address matches Exec Sheet
    • Executed via ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
    • Execution is NOT delegate call
    • IF SubDAO spell deployer is a smart contract (e.g. multisig or factory), ensure the deployer address is in addresses_deployers.sol as an entry
    • Ensure that SubDAO spell have enough gas and does not revert with "out of gas" error inside simulation. Note: low level call gas estimation is not done by our scripts
  • IF SubDAO provides instructions to be executed by the main spell (i.e. that will operate within Pause Proxy DelegateCall context)
    • No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
    • SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)
    • SubDAO contracts and all libraries / dependencies have verified source code (Blocking)
    • Upgradable SubDAO contracts
      • Upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)
      • Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)
    • All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Sheet and are correct. SubDAO addresses being authed or given any permissions MUST be in the Exec Sheet. SubDAO addresses being called must be confirmed by the SubDAO spell team.
    • IF addresses not PR'ed in by the SubDAO team (use git blame for example), SubDAO content addresses all have inline comment for provenance or source being OKed by SubDAO
    • SubDAO actions match Exec Sheet (only where inline with main spell code) and do not affect core contracts
    • Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the exec and match the code
    • External calls for SubDAO content are NOT delegate call
    • Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)
• IF external contracts calls are present (Not SubDAOs, e.g. Starknet)
  • Target Contract doesn't block spell execution
  • External call is NOT delegatecall
  • Target Contract doesn't have permissions on the Vat
  • Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)
  • Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code
  • MCD Pause Proxy doesn't give any approvals
  • All possible actions of the Target Contract are documented
  • Target contract is not upgradable
  • Target Contract is included in the ChainLog
  • Test Coverage is comprehensive
• IF spell interacts with ChainLog
  • ChainLog version is incremented based on update type
    • Major -> New Vat (++.0.0)
    • Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
    • Patch -> Collateral addition or addition/modification (0.0.++)
  • New addresses are added to the addresses_mainnet.sol
  • Changes are tested via testChainlogIntegrity and testChainlogValues
• Ensure every spell variable is declared as public/internal
• Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
  • Fetch addresses as type address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)
  • Use the DssExecLib Core Address Helpers where possible (e.g. DssExecLib.vat())
  • Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)
• Tests
  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    Insert most recent commit hash where CI was passing
    9d1cea5
  • Ensure every test function is declared as public
    • IF the test needs to run, it MUST NOT have the skipped modifier; OTHERWISE, it MUST have the skipped modifier
  • Ensure each spell action has sufficient test coverage
    List actions for which coverage was checked here
    • Office Hours Yes
      • Tested via testGeneral
    • Update PSM state variable in the conduit contracts to MCD_LITE_PSM_USDC_A
      • Tested via testRwaConduitsPsmUpdate
    • Phase 2 USDC Migration from PSM-USDC-A to LITE-PSM-USDC-A
      • Tested via test_LITE_PSM_USDC_A_MigrationPhase2 and testLitePSMs
    • Update PSM-USDC-A Fees
      • Tested via test_LITE_PSM_USDC_A_MigrationPhase2 and testPSMs
    • Update PSM-USDC-A DC-IAM
      • Tested via testGeneral
    • Update MCD_LITE_PSM_USDC_A Buf
      • Tested via test_LITE_PSM_USDC_A_MigrationPhase2
    • Update LITE-PSM-USDC-A DC-IAM
      • Tested via testGeneral
    • GSM Delay Update
      • Tested via testGeneral
    • Update LitePSM Keeper Network Job
      • Tested via test_CRON_LITE_PSM_JOB
    • Update CRON_LITE_PSM_JOB to 0x0c86162ba3e507592fc8282b07cf18c7f902c401 in the Chainlog
      • Tested via testChainlogIntegrity and testChainlogValues
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • Check all tests are passing locally using make test
    • Ensure every test listed in the coverage item above is present in the logs and with the [PASS] prefix.

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠰] Compiling 4 files with Solc 0.8.16
[⠒] Solc 0.8.16 finished in 2.39s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1661004)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 42.14s (35.70s CPU time)

Ran 37 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 1518180)
[PASS] testCastOnTime() (gas: 1515054)
[PASS] testChainlogIntegrity() (gas: 6064209)
[PASS] testChainlogValues() (gas: 9989256)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 11184)
[SKIP] testDAIPayments() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 4623035)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30353837)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 2441071)
[SKIP] testMKRPayments() (gas: 0)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495684)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2823452)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testRwaConduitsPsmUpdate() (gas: 1586080)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testUseEta() (gas: 352730)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
[PASS] test_CRON_LITE_PSM_JOB() (gas: 2687698)
[PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588161)
Suite result: ok. 16 passed; 0 failed; 21 skipped; finished in 380.81s (869.22s CPU time)

Ran 2 test suites in 381.60s (422.96s CPU time): 18 tests passed, 0 failed, 21 skipped (39 total tests)

Pre-Deployment Stage

• Wait till the Exec Doc is merged
• Exec Doc checks
  • Exec Doc for the specified date is found in the makerdao/community GitHub repo
    ℹ️ https://github.com/makerdao/community/blob/8d95eaf1c9eb6722008172504df88bc27f91ed3c/governance/votes/Executive%20vote%20-%20August%2022%2C%202024.md
  • Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
  • Extract permanent URL to the raw markdown file and paste it below
    Insert your Raw Exec Doc URL here
    https://raw.githubusercontent.com/makerdao/community/8d95eaf1c9eb6722008172504df88bc27f91ed3c/governance/votes/Executive%20vote%20-%20August%2022%2C%202024.md
  • Using Exec Doc URL from the above and the TARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
    Insert your Exec Doc Hash here
    ⚠️ Script fails with date: illegal option -- d, but the hash is generated via the command below
  • Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
    Insert your Exec Doc Hash here
    0xe3794c8152d2a1de72080b1fc7d8429a979015b3f41cbe2c26f755724c70951d
  • Make sure that hash above doesn't match keccak hash of the empty string (0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470)
  • Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below
    List all instructions announced in the Exec Doc
    • PSM state variables in the following conduit contracts will be updated to point to MCD_LITE_PSM_USDC_A
      • RWA014_A_INPUT_CONDUIT_URN
      • RWA014_A_INPUT_CONDUIT_JAR
      • RWA014_A_OUTPUT_CONDUIT
      • RWA007_A_JAR_INPUT_CONDUIT
      • RWA007_A_INPUT_CONDUIT
      • RWA007_A_OUTPUT_CONDUIT
      • RWA015_A_INPUT_CONDUIT_JAR_USDC
      • RWA015_A_INPUT_CONDUIT_URN_USDC
      • RWA015_A_OUTPUT_CONDUIT
      • RWA009_A_INPUT_CONDUIT_URN_USDC
    • Migrate Reserves from PSM-USDC-A to LITE-PSM-USDC-A
      • all but 200 million USDC reserves from PSM-USDC-A will be migrated to LITE-PSM-USDC-A.
    • PSM-USDC-A fees will be updated
      • PSM-USDC-A Fee In (tin) will be increased by 0.01 percentage points from 0% to 0.01%.
      • PSM-USDC-A Fee Out (tout) will be increased by 0.01 percentage points from 0% to 0.01%.
    • PSM-USDC-A DC-IAM parameters below will be updated as follows
      • PSM-USDC-A DC-IAM Maximum Debt Ceiling (line) will be decreased by 7,500 million DAI from 10,000 million DAI to 2,500 million DAI.
      • PSM-USDC-A DC-IAM Target Available Debt (gap) will be decreased by 180 million DAI from 380 million DAI to 200 million DAI.
      • PSM-USDC-A DC-IAM Ceiling Increase Cooldown (ttl) will remain unchanged at 12 hours.
    • Update MCD_LITE_PSM_USDC_A buf
      • MCD_LITE_PSM_USDC_A Fixed-sized Amount of Pre-minted Dai (buf) will be increased by 180 million DAI from 20 million DAI to 200 million DAI.
    • Update LITE-PSM-USDC-A DC-IAM Parameters
      • LITE-PSM-USDC-A DC-IAM Maximum Debt Ceiling (line) will be increased by 7,450 million DAI from 50 million DAI to 7,500 million DAI.
      • LITE-PSM-USDC-A DC-IAM Target Available Debt (gap) will be increased by 180 million DAI from 20 million DAI to 200 million DAI.
      • LITE-PSM-USDC-A DC-IAM Ceiling Increase Cooldown (ttl) will remain unchanged at 12 hours.
    • Update GSM Delay
      • The GSM Pause Delay will be increased by 14 hours from 16 hours to 30 hours.
    • Update LitePSM Keeper Network Job
      • The old LitePSM job will be removed from the CronSequencer through contract call sequencer.removejob(0x689cE517a4DfCf0C5eC466F2757D324fc292C8Be).
      • The new LitePSM job will be added to the CronSequencer through contract call sequencer.addjob(0x0c86162ba3e507592fc8282b07cf18c7f902c401).
        • fill: The rushThreshold will be set to 20 million DAI.
        • trim: The gushThreshold will be set to 20 million DAI.
        • chug: The cutThreshold will remain unchanged at 300,000 DAI.
      • The chainlog entry for CRON_LITE_PSM_JOB will be updated to 0x0c86162ba3e507592fc8282b07cf18c7f902c401.
  • Office hours value in the Exec Doc matches the spell
  • Sum of all payments in the Exec Doc matches the tests
  • Exec Doc URL in the spell comment matches your Raw Exec Doc URL above
  • Exec Doc URL in the spell comment refers to the https://github.com/makerdao/community repository
  • Every action present in the spell code is present in the Exec Doc
  • Every action in the Exec Doc is present in the spell code
• IF new commits are present in the spell
  • Copy relevant checklist items from the above and redo them
  • Ensure newly added code is covered by tests
  • Check if chainlog needs to be updated
  • Copy over and redo "Tests" section from the above
• IF all checks pass, make sure to include explicit "Good to deploy" comment

[0xp3th1um]

Mainnet Executive Spell Review Checklist

Development Stage

• Preparation

  • Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet
    Insert URL to the specific sheet here
    https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit?gid=175785542#gid=175785542
  • Using Exec Sheet URL from the above, read spell instructions from the Exec Sheet and list them below
    List all instructions announced in the Exec Sheet

    • Update PSM-USDC-A DC-IAM Update PSM state variable in the conduit contracts to MCD_LITE_PSM_USDC_A

      • RWA014_A_INPUT_CONDUIT_URN
      • RWA014_A_INPUT_CONDUIT_JAR
      • RWA014_A_OUTPUT_CONDUIT
      • RWA007_A_JAR_INPUT_CONDUIT
      • RWA007_A_INPUT_CONDUIT
      • RWA007_A_OUTPUT_CONDUIT
      • RWA015_A_INPUT_CONDUIT_JAR_USDC
      • RWA015_A_INPUT_CONDUIT_URN_USDC
      • RWA015_A_OUTPUT_CONDUIT
      • RWA009_A_INPUT_CONDUIT_URN_USDC

    • Phase 2 USDC Migration from PSM-USDC-A to LITE-PSM-USDC-A

      • Migrate all but 200 million USDC reserves from PSM-USDC-A to LITE-PSM-USDC-A

    • Update PSM-USDC-A Fees

      • PSM-USDC-A tin: Increase by 0.01 percentage points, from 0% to 0.01%
      • PSM-USDC-A tout: Increase by 0.01 percentage points, from 0% to 0.01%

    • Update PSM-USDC-A DC-IAM

      • PSM-USDC-A DC-IAM DC-IAM line: Decrease by 7,500 million DAI, from 10,000 million DAI to 2,500 million DAI.
      • PSM-USDC-A DC-IAM DC-IAM gap: Decrease by 180 million DAI, from 380 million DAI to 200 million DAI.
      • PSM-USDC-A DC-IAM DC-IAM ttl: 12h (Unchanged)

    • Update MCD_LITE_PSM_USDC_A Buf

      • MCD_LITE_PSM_USDC_A buf: Increase by 180 million DAI, from 20 million DAI to 200 million DAI

    • Update LITE-PSM-USDC-A DC-IAM

      • LITE-PSM-USDC-A DC-IAM line: Increase by 7,450 million DAI, from 50 million DAI to 7,500 million DAI.
      • LITE-PSM-USDC-A DC-IAM gap: Increase by 180 million DAI, from 20 million DAI to 200 million DAI.
      • LITE-PSM-USDC-A DC-IAM ttl: 12h (Unchanged)

    • GSM Delay Update

      • Increase the GSM Pause Delay by 14h, from 16h to 30h

    • Update LitePSM Keeper Network Job

      • Remove the old LitePSMJob (0x689cE517a4DfCf0C5eC466F2757D324fc292C8Be) from the CronSequencer
      • Add the new LitePSMJob (0x0c86162ba3e507592fc8282b07cf18c7f902c401) to the Cron Sequencer
      • fill: Set the rushThreshold to 20 million DAI
      • trim: Set the gushThreshold to 20 million DAI
      • chug: Set the cutThreshold to 300,000 DAI (Unchanged)
      • Update CRON_LITE_PSM_JOB to 0x0c86162ba3e507592fc8282b07cf18c7f902c401 in the Chainlog

• Base checks

  • Current solc version 0.8.16
  • Office hours is true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
  • Office hours value matches the Exec Sheet
  • 30 days spell expiry set in the constructor (block.timestamp + 30 days)

• Spell description

  • Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
  • TARGET_DATE in the description matches the target date
  • Accompanying comment above spell description follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"

• Comments inside the spell

  • Every Section text from the Exec Sheet is copied to the spell code as a comment surrounded by the set of dashes (E.g. // ----- Section text -----)
  • Every Instruction text from the Exec Sheet is copied to the spell code as // Instruction text
  • Every Instruction text have newline above it
  • IF an instruction can not be taken, it should have explanation under the instruction prefixed with // Note: (e.g.: // Note: Payments are skipped on goerli)
  • IF action in the spell doesn't have relevant instruction (e.g.: chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL have prefix derived from the url itself
    • // Executive Vote: if URL starts with https://vote.makerdao.com/executive/
    • // Poll: if URL starts with https://vote.makerdao.com/polling/
    • // Forum: if URL starts with https://forum.makerdao.com/t/
    • // MIP: if URL starts with https://mips.makerdao.com/mips/details/

• Dependency checks

  • Update Foundry by running foundryup
  • Reinstall libraries by running rm -rf ./lib && git submodule update --init --recursive

    Insert checked out submodule paths here
    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
    Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
    Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'
    Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-test/lib/forge-std': checked out '155d547c449afa8715f538d69454b83944117811'
    Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'e282159d5170298eb2455a6c05280ab5a73a4ef0'
    

  • IF submodule upgrades are present, make sure dss-exec-lib is synced as well
  • git submodule hash of dss-exec-lib (run git submodule status) matches the latest release version or newer
  • dss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-test

• IF interfaces are present in the spell

  • Interfaces imported from dss-interfaces
    • No unused dss-interfaces
    • Only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)
      ℹ️ Not done, but not critical!
  • Static Interfaces
    • No unused static interfaces
    • Declared static interface not present in the dss-interfaces, OTHERWISE should be imported from there
      ℹ️ Skipped for convenience in some cases
    • Interface matches deployed contract using cast interface <contract_address> command
    • Interface naming style should match with Like suffix (e.g. VatLike)
      • EXCEPTION: known interface naming exceptions
    • Each static interface declare only functions actually used in the spell code

• IF variable declarations are present in the spell

  • IF precision units are present
    • Precision units used in the spell match their defined values:
      • WAD = 10 ** 18
      • RAY = 10 ** 27
      • RAD = 10 ** 45
    • Precision units match with Numerical Ranges
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
  • IF math units are present
    • Match their defined values:
      • HUNDRED = 10 ** 2
      • THOUSAND = 10 ** 3
      • MILLION = 10 ** 6
      • BILLION = 10 ** 9
    • Match with config
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
  • IF rates are present
    • Rates match generated locally via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Rates match IPFS document
    • Rate variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)
    • Rate variable visibility declared as internal
    • Rate variable state mutability declared as constant
  • IF timestamps are present
    • Comment above timestamp states full date including UTC timezone
    • Timestamp converts back to the correct date
    • Timestamp converts back to the UTC timezone
    • Variable naming matches MMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)
    • Time of day makes logical sense in the context of timestamp usage (i.e. 23~~:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant

• IF new contract is present in the spell (not yet on chainlog or new to chainlog)

  • CRON_LITE_PSM_JOB_NEW (LitePsmJob) - 0x0C86162ba3E507592fC8282b07cF18c7F902C401
  • Source code is verified on etherscan
  • Compilation optimizations match deployment settings defined in the source code repo
  • GNU AGPLv3 license
  • Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
  • IF new contract have concept of wards or access control
    • Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
    • Ensure that contract deployer address was denied (wards(deployer) is 0)
    • Ensure MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)
    • Ensure that there are no other Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)
  • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
  • Deployer address is included into addresses_deployers.sol

• IF core system parameter changes are present in the instructions

  • IF stability fee (jug.ilk.duty) is updated
    • (DssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used
    • Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
  • IF Dai Savings Rate (pot.dsr) is updated
    • (DssExecLib.setDSR(rate, doDrip)) is used
    • Comment matches pattern // Increase DSR by X.XX% from X.XX% to X.XX%
    • Double check that rate match make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Double check that rate match IPFS document
  • IF spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is used
  • IF dog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is used
  • IF vat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is used
  • IF dog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is used
  • IF clip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is used
  • IF clipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is used
  • IF clip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is used
  • IF clip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is used
  • IF clip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is used
  • IF clip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is used
  • IF calc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is used
  • IF calc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is used

• IF debt ceiling changes are present in the instructions

  • IF adjusted collateral type (ilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)
    • IF collateral debt ceiling requested to be 0
      • Collateral is removed from AutoLine (MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)
      • The instruction to remove from AutoLine (MCD_IAM_AUTO_LINE) is present in the Exec Sheet
      • Collateral debt ceiling is set to 0 via DssExecLib.setIlkDebtCeiling(ilk, amount)
      • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to
    • IF AutoLine parameters are updated
      • EITHER is used, depending on the instruction:
        • DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
        • DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
          ℹ️ Neither is used but not a problem since it is made via autoLine.setIlk() in the migration script!
  • IF collateral debt ceiling (vat.ilk.line) is updated
    • Collateral type (ilk) have AutoLine disabled previously or in the spell
    • EITHER is used, depending on the instruction:
      • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.setIlkDebtCeiling(ilk, amount)
    • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
      • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
      • DssExecLib.setGlobalDebtCeiling(amount)
      • DssExecLib.increaseGlobalDebtCeiling(amount)
      • DssExecLib.decreaseGlobalDebtCeiling(amount)

• IF additional dependencies (i.e. ./src/dependencies/ directory) are present:

  • IF the dependencies contracts/libraries have been audited
    • Each contract/library exactly matches (i.e. diff check) the source code of the latest audited version
      ℹ️ The migration code is taken from the dss-lite-psm repo which contains the following audits:
    • https://github.com/makerdao/dss-lite-psm/blob/main/audits/ChainSecurity_MakerDAO_PSM_Lite_audit.pdf
    • https://github.com/makerdao/dss-lite-psm/blob/main/audits/report-review-makerdao-dss-lite-psm.pdf
  • OTHERWISE obtain the permalink to the relevant repository from a trusted party (i.e. Gov Facilitators)
    • Each contract/library exactly matches (i.e. diff check) the source code from the permalink

• IF onboarding is present

  • Insert and follow the relevant checklists below:
    • Collateral Onboarding
    • RWA Onboarding
    • Teleport Onboarding

• IF PSM migration, onboarding or offboarding is present:

  • Insert and follow the relevant checklists below:
    • PSM Checklists

    PSM Checklists

PSM Migration Checklist

• IF LitePSM MOM is being on-boarded in the current spell, execute the full LitePSM MOM Onboarding Checklist
• IF LitePSM contracts are being on-boarded in the current spell, execute the full LitePSM Onboarding Checklist
• IF a PSM is deprecated in the migration, execute the full PSM Offboarding Checklist
• IF present, max amount of gems to move (dstWant) matches the Exec Sheet
• IF present, min amount of gems to keep (srcKeep) matches the Exec Sheet
• Source PSM:
  • ilk matches source PSM
  • IF present, tin matches the value in the Exec Sheet
  • IF present, tout matches the value in the Exec Sheet
  • AutoLine is updated according to the Exec Sheet
• Destination PSM:
  • ilk matches destination PSM
  • IF present, tin matches the value in the Exec Sheet
  • IF present, tout matches the value in the Exec Sheet
  • AutoLine is updated according to the Exec Sheet~~
  • buf matches the value in the Exec Sheet
  • fill is called conditionally (if(rush() > 0)) to ensure liquidity is immediately available after spell execution
• Test coverage:
  • Collateral amount that is fetched from the source PSM matches the collateral is added to the destination PSM
    • vat.urns(DST_ILK, dstPsm).art is increased at least by the moved amount
    • gem balance of dstPocket is increased exactly by the moved amount
    • Dai balance of dstPsm is equal to dstBuf, UNLESS limited by the debt ceiling (line)
    • vat.urns(SRC_ILK, srcPsm).art is decreased exactly by the moved amount
    • vat.urns(SRC_ILK, srcPsm).ink is decreased exactly by the moved amount
    • gem balance of srcPsm.gemJoin() is decreased exactly by the moved amount
  • No bad debt is left behind
    • vat.vice() is unchanged after the spell execution
    • vat.sin(MCD_PAUSE_PROXY) is unchanged after the spell execution

LitePSM MOM Onboarding Checklist

• Deployed Contracts
  • DssLitePsmMom
    • Optimizer is enabled
    • Optimize runs is set to 200
    • Contract has been reviewed by minimum 2 specialized Active Ecosystem Actors
    • Contract has been audited by an external party
      • Audit report source could be confirmed (i.e. found on auditor's website)
      • All issues found were fixed or acknowledged
      • No code changes are done after final audit report, based on the commit hash found in the report +
        • EITHER code diff check for each individual file
        • OR bytecode verification tool such as forge verify-bytecode
    • Deployed contract matches the code in the repo
    • Deployer is no longer the owner
    • MCD_PAUSE_PROXY is the owner of the contract (i.e. require(MomLike(MOM).owner() == MCD_PAUSE_PROXY))
• Initialization:
  • DssLitePsmMom:
    • The chief (MCD_ADM) is set as the authority (i.e. MomLike(MOM).setAuthority(MCD_ADM))
• Test Coverage:
  • DssLitePsmMom:
    • The chief (MCD_ADM) is set as the authority (i.e. MomLike(MOM).setAuthority(MCD_ADM))

LitePSM Onboarding Checklist

• Deployed Contracts
  • DssLitePsm
    • Optimizer is enabled
    • Optimize runs is set to 200
    • Contract has been reviewed by minimum 2 specialized Active Ecosystem Actors
    • Contract has been audited by an external party
      • Audit report source could be confirmed (i.e. found on auditor's website)
      • All issues found were fixed or acknowledged
      • No code changes are done after final audit report, based on the commit hash found in the report +
        • EITHER code diff check for each individual file
        • OR bytecode verification tool such as forge verify-bytecode
    • Deployed contract matches the code in the repo
    • Constructor params:
      • ilk is named LITE-PSM-{TOKEN_SYMBOL}-A (i.e. LITE-PSM-USDC-A)
      • gem matches the expected token address
      • daiJoin matches MCD_JOIN_DAI from the chainlog
      • pocket matches the pocket address in the Exec Sheet
    • Deployer no longer has privileged access (wards(deployer) == 0)
    • MCD_PAUSE_PROXY has been authed (i.e. require(WardsLike({LITE_PSM}).wards(MCD_PAUSE_PROXY) == 1))
    • ~~Sanity check: DssLitePsm has type(uint256).max approval to spend gem on behalf of pocket
  • LitePsmJob
    • CRON_LITE_PSM_JOB_NEW (LitePsmJob) - 0x0C86162ba3E507592fC8282b07cF18c7F902C401
    • Uses the default Solidity version in dss-cron
    • Optimizer is enabled
    • Deployed contract matches the code in the repo
    • Constructor params:
      • _sequencer matches CRON_SEQUENCER address from the chainlog
      • _litePsm matches {LITE_PSM} address
      • _rushThreshold matches the Exec Sheet (it might be named as "fill threshold")
      • _gushThreshold matches the Exec Sheet (it might be named as "trim threshold")
      • _cutThreshold matches the Exec Sheet (it might be named as "chug threshold")
• Initialization
  • DssLitePsm:
    • buf is set to the value specified in the Exec Sheet
    • vow is set to MCD_VOW from the chainlog
    • MCD_PAUSE_PROXY is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).kiss(MCD_PAUSE_PROXY))
    • DssLitePsmMom is authed (i.e. RelyLike({LITE_PSM}).rely(MOM))
  • LitePsmJob:
    • Job is added to CRON_SEQUENCER
  • MCD_VAT:
    • New ilk is initialized
  • MCD_JUG:
    • New ilk is initialized
  • MCD_SPOT:
    • Sanity check: Dai parity (par) current value is 1 (1 * RAY)
    • Collateralization ratio (mat) is set to 100% (1 * RAY) for the ilk
    • IF a new pip is being used:
      • pip is set for the ilk
      • pip is a DSValue instance
      • The value on pip is set to 1 (1 * WAD)
      • pip deployer is no longer the owner
      • MCD_PAUSE_PROXY is the owner on pip
    • OTHERWISE when reusing an existing pip:
      • pip is set for the ilk
      • pip in the chainlog matches gem symbol (i.e. PIP_USDC for USDC)
  • ILK_REGISTRY:
    • New ilk is added to the registry
  • CHAINLOG:
    • DssLitePsm is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
    • pocket is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
    • DssLitePsmMom is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
    • LitePsmJob is added to the chainlog and addresses_mainnet.sol according to the Exec Sheet
    • IF a new pip is being added, it is added to the chainlog and addresses_mainnet.sol as PIP_{TOKEN_SYMBOL} (i.e. PIP_USDC)
• Test coverage:

  • DssLitePsm:

    • vow is set to MCD_VOW
    • buf matches the Exec Sheet
    • MCD_PAUSE_PROXY is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).bud(MCD_PAUSE_PROXY) == 1)
    • DssLitePsmMom is authed (i.e. WardsLike({LITE_PSM}).wards(MOM) == 1)
    • E2E tests:
      • buyGem works as expected
      • sellGem works as expected
      • buyGemNoFee works as expected
      • sellGemNoFee works as expected

  • DssLitePsmMom:

    • E2E tests:
      • halt prevents new swaps in {LITE_PSM}

  • LitePsmJob:

    • Job is added to CRON_SEQUENCER (i.e.: SequencerLike(CRON_SEQUENCER).hasJob(LITE_PSM_JOB) == true)
    • sequencer matches CRON_SEQUENCER address from the chainlog
    • litePsm matches {LITE_PSM} address
    • rushThreshold matches the Exec Sheet (it might be named as "fill threshold")
    • gushThreshold matches the Exec Sheet (it might be named as "trim threshold")
    • cutThreshold matches the Exec Sheet (it might be named as "chug threshold")
    • E2E tests:
      • work has the desired effect:
        • IF rush() > _rushThreshold, fill is called
        • OTHERWISE IF cut() > _cutThreshold, chug is called
        • OTHERWISE IF gush() > _gushThreshold, trim is called
        • OTHERWISE it reverts

    ✅ done via test_CRON_LITE_PSM_JOB()

  • MCD_VAT:

    • urns[ilk][{LITE_PSM}].ink is set to the max value that will not cause an overflow (int256(type(uint256).max / RAY))

  • MCD_JUG:

    • Stability fee (duty) is set to 0% (1 * RAY) for the ilk (:information_source: covered in config.sol)

  • MCD_SPOT:

    • spotter(DST_ILK).mat is set to 100% (1 * RAY) (:information_source: covered in config.sol)
    • spotter(DST_ILK).pip is set correctly

  • CHAINLOG:

    • Version is bumped: {x}.{y}.{z+1} (:information_source: covered in config.sol)

  • ILK_REGISTRY:

    • New ilk is added to the registry
    • name matches gem name
    • symbol matches gem symbol
    • class for join-less ilks is used (REG_CLASS = 6)
    • gem matches the configured gem
    • pip matches the configured pip
    • gemJoin is set to address(0)
    • clip is set to address(0)

PSM Offboarding Checklist

• ilk is removed from AutoLine
• ilk line is set to 0
• ink for the PSM is set to 0 on MCD_VAT after execution, UNLESS there has been a donation
• Global Line is adjusted accordingly
• ilk is removed from ILK_REGISTRY
• PSM contracts (Psm, GemJoin and others, as applicable) are being removed from the chainlog
• Chainlog version is bumped: {x}.{y+1}.0
• PSM contracts (Psm, GemJoin and others, as applicable) are being scuttled
  • MCD_PAUSE_PROXY is de-authed from all applicable contracts

• IF collateral offboarding is present in the spell
  • ~~1st stage collateral offboarding
    • Collateral type (ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabled
    • Collateral debt ceiling (vat.ilk.line) is set to 0
    • Global debt ceiling (vat.Line) decreased by the total amount of offboarded ilks
  • 2nd stage collateral offboarding
    • All actions from the 1st stage offboarding are previously taken (EITHER in the current or past spells – check the archive)
    • Collateral liquidation penalty (chop) is set to 0 IF requested by governance
    • Flat keeper incentive (tip) is set to 0 IF requested by governance
    • Relative keeper incentive (chip) is set to 0 IF requested by governance
    • Max liquidation amount (hole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governance
    • Relevant clipper contract (MCD_CLIP_) is active (i.e. stopped is 0)
    • Liquidations are triggered via (depending on governance instruction):
      • EITHER liquidation ratio (spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))
      • OR via enabling linear interpolation (DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))
        • Ensure name format matches "XXX-X Offboarding"
        • Ensure target matches DssExecLib.spotter() address
        • Ensure ilk format matches collateral type (ilk) name ("XXX-X")
        • Ensure what matches string "mat"
        • Ensure startTime matches block.timestamp
        • Ensure start uses variable CURRENT_XXX_A_MAT
        • Ensure start matches current spotter.ilk.mat value
        • Ensure end uses variable TARGET_XXX_A_MAT
        • Ensure end value matches the instruction
        • Ensure end allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)
        • Ensure duration matches the instruction
    • Spotter price is updated via DssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)
    • Spotter price is updated after all other actions
    • Offboarding is tested at least via _checkIlkClipper helper
• IF RWA updates are present
  • IF doc is updated
    • _updateDoc helper is copied one-to-one from the archive and defined above actions
    • _updateDoc(ilk, doc) is called in the spell
  • IF debt ceiling is updated
    • IF AutoLine update is requested by the Exec Sheet
      • Parameters are set via DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
    • IF regular debt ceiling (vat.ilk.line) update is requested by the Exec Sheet
      • Collateral type (ilk) have AutoLine disabled previously or in the spell
      • Debt ceiling (vat.ilk.line) is updated, via EITHER:
        • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
        • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
        • DssExecLib.setIlkDebtCeiling(ilk, amount)
      • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
        • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
        • DssExecLib.setGlobalDebtCeiling(amount)
        • DssExecLib.increaseGlobalDebtCeiling(amount)
        • DssExecLib.decreaseGlobalDebtCeiling(amount)~~
    • Liquidation oracle price is bumped via RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) pattern
      • Comment above bump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"
      • Comment above bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)
        • The formula matches the example provided above
        • debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLine
        • rwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chain
        • minimum_deal_duration_in_years in the executable formula matches number found in the Exec Sheet of the spell containing relevant RWA onboarding
        • liquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chain
        • Executing formula locally provides integer number that matches the val in the spell
      • val makes sense in context of the rate mechanism
    • IF multiple RWA ilks are being combined into one, val calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal
    • Oracle price is updated via DssExecLib.updateCollateralPrice(ilk)
    • IF soft liquidation explicitly requested to be triggered (via .tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)
      • RwaLiquidationOracle.tell(ilk) call is present
      • IF RWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)
• IF payments are present in the spell
  • IF MKR transfers are present
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • Transfer amount is specified with (at least) 2 decimals using ether keyword
    • IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
    • The transfers are tested via testMKRPayments test
    • Sum of all MKR transfers tested in testMKRPayments matches number in the Exec Sheet
  • IF DAI surplus buffer transfers are present
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • The transfers are tested via testDAIPayments test
    • Sum of all DAI transfers tested in testDAIPayments matches number in the Exec Sheet
  • IF MKR or DAI streams (DssVest) are created
    • VestAbstract interface is imported from dss-interfaces/dss/VestAbstract.sol
    • restrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Sheet
    • usr (Vest recipient address) matches Exec Sheet
    • usr address in the instruction is in the checksummed format
    • usr address variable name match one found in addresses_wallets.sol
    • tot (Total stream amount) matches Exec Sheet
    • IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
    • IF vest amount is expressed in 'per year' or similar in the Exec Sheet, account for leap days
    • bgn (Vest start timestamp) matches Exec Sheet
    • tau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • fin (Vest end timestamp) matches Exec Sheet
    • eta (Vest cliff duration) matches the following logic
      • ~~IF eta is explicitly specified in the Exec Sheet, then the values match
      • ~~IF eta and clf (Cliff end timestamp) are not specified in the Exec Sheet, then eta is 0
      • ~~IF clf is specified, but clf <= bgn, then eta is 0
      • IF clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • IF mgr (Vest manager address) is specified in the Exec Sheet, matches the value, OTHERWISE matches address(0)
    • Ensure that max vesting rate (cap) is enough for the new streams
      • The maximum vesting rate (tot divided by tau) <= the maximum vest streaming rate (cap)
      • The maximum vesting rate (tot divided by tau) > the maximum vest streaming rate (cap)
      • Calculate new cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)
    • IF max vesting rate (cap) is changed in the spell
      • Governance facilitators were notified
      • Exec Sheet contain explicit instruction
      • Exec Sheet contain explicit instruction
    • IF MKR stream (DssVestTransferrable) is present
      • Vest contract's MKR allowance increased by the cumulative total (the sum of all tot values)
      • Ensure allowance increase follows archive patterns
    • Tested via testVestDAI or testVestMKR
  • IF MKR or DAI vest termination (Yank) is present
    • Yanked stream ID matches Exec Sheet
    • MCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yank
    • MCD_VEST_DAI chainlog address is used for DAI stream yank
    • Tested via testYankDAI or testYankMKR
• IF SubDAO-related content is present
  • IF SubDAO provides SubProxy spell address
    • SubDAO spell address matches Exec Sheet
    • Executed via ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
    • Execution is NOT delegate call
    • IF SubDAO spell deployer is a smart contract (e.g. multisig or factory), ensure the deployer address is in addresses_deployers.sol as an entry
    • Ensure that SubDAO spell have enough gas and does not revert with "out of gas" error inside simulation. Note: low level call gas estimation is not done by our scripts
  • IF SubDAO provides instructions to be executed by the main spell (i.e. that will operate within Pause Proxy DelegateCall context)
    • No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
    • SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)
    • SubDAO contracts and all libraries / dependencies have verified source code (Blocking)
    • Upgradable SubDAO contracts~~
      • Upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)
      • Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)
    • All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Sheet and are correct. SubDAO addresses being authed or given any permissions MUST be in the Exec Sheet. SubDAO addresses being called must be confirmed by the SubDAO spell team.
    • IF addresses not PR'ed in by the SubDAO team (use git blame for example), SubDAO content addresses all have inline comment for provenance or source being OKed by SubDAO
    • SubDAO actions match Exec Sheet (only where inline with main spell code) and do not affect core contracts
    • Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the exec and match the code
    • External calls for SubDAO content are NOT delegate call
    • Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)
• IF external contracts calls are present (Not SubDAOs, e.g. Starknet)
  • Target Contract doesn't block spell execution
  • External call is NOT delegatecall
  • Target Contract doesn't have permissions on the Vat
  • Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)
  • Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code
  • MCD Pause Proxy doesn't give any approvals
  • All possible actions of the Target Contract are documented
  • Target contract is not upgradable
  • Target Contract is included in the ChainLog
  • Test Coverage is comprehensive
• IF spell interacts with ChainLog
  • ChainLog version is incremented based on update type
    • Major -> New Vat (++.0.0)
    • Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
    • Patch -> Collateral addition or addition/modification (0.0.++)
  • New addresses are added to the addresses_mainnet.sol
  • Changes are tested via testChainlogIntegrity and testChainlogValues
• Ensure every spell variable is declared as public/internal
• Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
  • Fetch addresses as type address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)
  • Use the DssExecLib Core Address Helpers where possible (e.g. DssExecLib.vat())
  • Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)
• Tests
  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    Insert most recent commit hash where CI was passing
    9d1cea5
  • Ensure every test function is declared as public
    • IF the test needs to run, it MUST NOT have the skipped modifier; OTHERWISE, it MUST have the skipped modifier
  • Ensure each spell action has sufficient test coverage
    List actions for which coverage was checked here
    [x] Update PSM state variable in the conduit contracts to MCD_LITE_PSM_USDC_A
    ✅ testRwaConduitsPsmUpdate()
    [x] Phase 2 USDC Migration from PSM-USDC-A to LITE-PSM-USDC-A
    [x] Update PSM-USDC-A Fees
    [x] Update PSM-USDC-A DC-IAM
    [x] Update MCD_LITE_PSM_USDC_A Buf
    [x] Update LITE-PSM-USDC-A DC-IAM
    ✅ test_LITE_PSM_USDC_A_MigrationPhase2(), testLitePSMs & testGeneral() and editing config.sol properly
    [x] GSM Delay Update
    ✅ testGeneral() and editing config.sol properly
    [x] Update LitePSM Keeper Network Job & Bump chainlog version
    ✅ test_CRON_LITE_PSM_JOB() & testChainlogIntegrity() & testChainlogValues()
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • Check all tests are passing locally using make test
    • Ensure every test listed in the coverage item above is present in the logs and with the [PASS] prefix.

_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠰] Compiling 4 files with Solc 0.8.16
[⠔] Solc 0.8.16 finished in 1.37s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1660987)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 36.14s (30.39s CPU time)

Ran 37 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 1518163)
[PASS] testCastOnTime() (gas: 1515037)
[PASS] testChainlogIntegrity() (gas: 6064192)
[PASS] testChainlogValues() (gas: 9989239)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 11184)
[SKIP] testDAIPayments() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 4623035)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30353820)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 2441054)
[SKIP] testMKRPayments() (gas: 0)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495577)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2823438)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testRwaConduitsPsmUpdate() (gas: 1586063)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testUseEta() (gas: 352730)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
[PASS] test_CRON_LITE_PSM_JOB() (gas: 2694693)
[PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588144)
Suite result: ok. 16 passed; 0 failed; 21 skipped; finished in 401.01s (942.76s CPU time)

Ran 2 test suites in 401.95s (437.15s CPU time): 18 tests passed, 0 failed, 21 skipped (39 total tests)

Pre-Deployment Stage

• Wait till the Exec Doc is merged
• Exec Doc checks

  • Exec Doc for the specified date is found in the makerdao/community GitHub repo

  • Exec Doc file name follows the format Executive vote - Month DD, YYYY.md

  • Extract permanent URL to the raw markdown file and paste it below
    Insert your Raw Exec Doc URL here
    https://raw.githubusercontent.com/makerdao/community/8d95eaf1c9eb6722008172504df88bc27f91ed3c/governance/votes/Executive%20vote%20-%20August%2022%2C%202024.md

  • Using Exec Doc URL from the above and the TARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
    ℹ️ The script is not working locally
    Insert your Exec Doc Hash here

  • Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
    Insert your Exec Doc Hash here
    0xe3794c8152d2a1de72080b1fc7d8429a979015b3f41cbe2c26f755724c70951d

  • Make sure that hash above doesn't match keccak hash of the empty string (0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470)

  • Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below
    List all instructions announced in the Exec Doc

    • Update PSM State Variables in Conduit Contracts

      • The PSM state variables in the following conduit contracts will be updated to point to MCD_LITE_PSM_USDC_A:

        • RWA014_A_INPUT_CONDUIT_URN
        • RWA014_A_INPUT_CONDUIT_JAR
        • RWA014_A_OUTPUT_CONDUIT
        • RWA007_A_JAR_INPUT_CONDUIT
        • RWA007_A_INPUT_CONDUIT
        • RWA007_A_OUTPUT_CONDUIT
        • RWA015_A_INPUT_CONDUIT_JAR_USDC
        • RWA015_A_INPUT_CONDUIT_URN_USDC
        • RWA015_A_OUTPUT_CONDUIT
        • RWA009_A_INPUT_CONDUIT_URN_USDC

    • Migrate Reserves from PSM-USDC-A to LITE-PSM-USDC-A

      • All but 200 million USDC reserves from PSM-USDC-A will be migrated to LITE-PSM-USDC-A

    • Update PSM-USDC-A Fees
      The PSM-USDC-A fees will be updated as follows:

      • PSM-USDC-A Fee In (tin) will be increased by 0.01 percentage points from 0% to 0.01%.
      • PSM-USDC-A Fee Out (tout) will be increased by 0.01 percentage points from 0% to 0.01%.

    • Update PSM-USDC-A DC-IAM Parameters

      • The PSM-USDC-A DC-IAM parameters below will be updated as follows:

        • PSM-USDC-A DC-IAM Maximum Debt Ceiling (line) will be decreased by 7,500 million DAI from 10,000 million DAI to 2,500 million DAI.
        • PSM-USDC-A DC-IAM Target Available Debt (gap) will be decreased by 180 million DAI from 380 million DAI to 200 million DAI.
        • PSM-USDC-A DC-IAM Ceiling Increase Cooldown (ttl) will remain unchanged at 12 hours.

    • Update MCD_LITE_PSM_USDC_A buf

      • The MCD_LITE_PSM_USDC_A fixed-sized amount of pre-minted Dai (buf) will be increased as follows:

        • MCD_LITE_PSM_USDC_A Fixed-sized Amount of Pre-minted Dai (buf) will be increased by 180 million DAI from 20 million DAI to 200 million DAI

    • Update LITE-PSM-USDC-A DC-IAM Parameters

      • The LITE-PSM-USDC-A DC-IAM will be updated as follows:

        • LITE-PSM-USDC-A DC-IAM Maximum Debt Ceiling (line) will be increased by 7,450 million DAI from 50 million DAI to 7,500 million DAI.
        • LITE-PSM-USDC-A DC-IAM Target Available Debt (gap) will be increased by 180 million DAI from 20 million DAI to 200 million DAI.
        • LITE-PSM-USDC-A DC-IAM Ceiling Increase Cooldown (ttl) will remain unchanged at 12 hours.

    • Update GSM Delay

      • the GSM Pause Delay will be updated as follows:

        • The GSM Pause Delay will be increased by 14 hours from 16 hours to 30 hours.

    • Update LitePSM Keeper Network Job

      • The LitePSM Keeper Network Job will be updated with the following contract calls and parameters, as a consequence of the LITE-PSM-USDC-A DC-IAM and buf parameter changes described earlier in this document:

        • The old LitePSM job will be removed from the CronSequencer through contract call sequencer.removejob(0x689cE517a4DfCf0C5eC466F2757D324fc292C8Be).
        • The new LitePSM job will be added to the CronSequencer through contract call sequencer.addjob(0x0c86162ba3e507592fc8282b07cf18c7f902c401).
        • fill: The rushThreshold will be set to 20 million DAI.
        • trim: The gushThreshold will be set to 20 million DAI.
        • chug: The cutThreshold will remain unchanged at 300,000 DAI.
        • The chainlog entry for CRON_LITE_PSM_JOB will be updated to 0x0c86162ba3e507592fc8282b07cf18c7f902c401.

  • Office hours value in the Exec Doc matches the spell

  • Sum of all payments in the Exec Doc matches the tests

  • Exec Doc URL in the spell comment matches your Raw Exec Doc URL above

  • Exec Doc URL in the spell comment refers to the https://github.com/makerdao/community repository

  • Every action present in the spell code is present in the Exec Doc

  • Every action in the Exec Doc is present in the spell code

• IF new commits are present in the spell
  • Copy relevant checklist items from the above and redo them
  • Ensure newly added code is covered by tests
  • Check if chainlog needs to be updated
  • Copy over and redo "Tests" section from the above
• IF all checks pass, make sure to include explicit "Good to deploy" comment

[oddaf]

Spell deployed

Spell address: 0x969c91C5aC11D4d1077A6aAF3d2BA617906543Cc
Tenderly testnet: https://dashboard.tenderly.co/explorer/vnet/1d03288b-c368-4275-bd1f-2cdc16c4c143

[SidestreamColdMelon]

TLDR: Good to handover

Deployed Stage

• Source code settings
  • Deployed spell is verified on etherscan
  • Optimization enabled: false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failed
  • Default evmVersion
  • GNU AGPLv3 license
• Source code validity
  • Deployed spell code matches source on github. (can be checked via make diff-deployed-spell or manually)
  • No new changes are made after previously given "good to deploy"
• Deployed spell Etherscan checks
  • Automated checks via make check-deployed-spell
    • Verified
    • Valid license
      ⚠️ The script says "DssSpell was verified with an invalid or unknown license", but the licence type shown in the etherscan UI (GNU GPLv3) and visible in the verified code (AGPL-3.0-or-later) matches licence found in the spell itself
    • Version matches
    • Optimizations are disabled
    • dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • deployed_spell_created matches deployment timestamp
    • deployed_spell_block matches deployment block number
  • Manual checks
    • Ensure make deploy-info tx=<tx> matches config
      • deployed_spell_created timestamp
      • deployed_spell_block block number
    • Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
    • Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
      ⚠️ The hash doesn't match as in multiple previous spells. Latest release v0.0.9 has hash of c0d3c6c made on Feb 1, 2022, while git submodule lib/dss-exec-lib is set to track the latest commit 69b658f made on Jan 23, 2023. Here is the diff between the latest release and the submodule: makerdao/dss-exec-lib@v0.0.9...69b658f#diff-72201ff20380f5c7fc89281be3ad2dd6bd5a992f246d41d6d9d97f71e078d40d. The only major difference between deployed and the imported library is the new setRWAIlkDebtCeiling, which we're not using in this particular spell
• Tenderly Testnet checks
  • A testnet with the name matching spell description is found at maker dashboard
  • The testnet name is unique (previous testnets does not have the same name)
  • Cast transaction is set to the correct "receiver" (matches deployed spell address)
  • All actions are executed in the transaction trace
  • No reverts are present that block execution
  • No out-of-gas errors are present
• Archive checks
  • make diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"
  • Ensure date corresponds to target Exec Doc date
• Tests
  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    Insert most recent commit hash where CI was passing
    fe59ff6
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • Check all tests are passing locally using make test

_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠔] Compiling 4 files with Solc 0.8.16
[⠒] Solc 0.8.16 finished in 2.47s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1660987)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 37.33s (34.37s CPU time)

Ran 37 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 4643839)
[PASS] testCastCost() (gas: 1518163)
[PASS] testCastOnTime() (gas: 1515037)
[PASS] testChainlogIntegrity() (gas: 6064192)
[PASS] testChainlogValues() (gas: 9989239)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDAIPayments() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30355917)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 2441054)
[SKIP] testMKRPayments() (gas: 0)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495577)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2823438)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testRwaConduitsPsmUpdate() (gas: 1586063)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testUseEta() (gas: 352730)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
[PASS] test_CRON_LITE_PSM_JOB() (gas: 2687681)
[PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588144)
Suite result: ok. 15 passed; 0 failed; 22 skipped; finished in 396.88s (850.85s CPU time)

Ran 2 test suites in 397.65s (434.21s CPU time): 17 tests passed, 0 failed, 22 skipped (39 total tests)

• Additional checks
  • testBytecodeMatches pass
  • No delegatecall code inside verified code
  • No selfdestruct code present in the deployed code

[0xp3th1um]

Good to handover!

Deployed Stage

• Source code settings
  • Deployed spell is verified on etherscan
  • Optimization enabled: false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failed
  • Default evmVersion
  • GNU AGPLv3 license
• Source code validity
  • Deployed spell code matches source on github. (can be checked via make diff-deployed-spell or manually)
    ℹ️ Checked manually as the addition of libraries makes the script report mismatches!
  • No new changes are made after previously given "good to deploy"
• Deployed spell Etherscan checks
  • Automated checks via make check-deployed-spell
    • Verified
    • Valid license
      ℹ️ Fails but not critical as it has been checked manually!
    • Version matches
    • Optimizations are disabled
    • dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • deployed_spell_created matches deployment timestamp
    • deployed_spell_block matches deployment block number
  • Manual checks
  • Ensure make deploy-info tx=<tx> matches config
    • deployed_spell_created timestamp
      ℹ️ timestamp: 1724332103
    • deployed_spell_block block number
      ℹ️ block: 20584345
    • Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
    • Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
      ℹ️ Step above skipped, there is a current mismatch as in previous spells, not critical
• Tenderly Testnet checks
  • A testnet with the name matching spell description is found at maker dashboard
  • The testnet name is unique (previous testnets does not have the same name)
  • Cast transaction is set to the correct "receiver" (matches deployed spell address)
  • All actions are executed in the transaction trace
  • No reverts are present that block execution
  • No out-of-gas errors are present
• Archive checks
  • make diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"
  • Ensure date corresponds to target Exec Doc date
• Tests
  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    Insert most recent commit hash where CI was passing
    fe59ff6
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • Check all tests are passing locally using make test

_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠰] Compiling 4 files with Solc 0.8.16
[⠔] Solc 0.8.16 finished in 1.39s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1660987)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 40.01s (35.83s CPU time)

Ran 37 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 4643839)
[PASS] testCastCost() (gas: 1518163)
[PASS] testCastOnTime() (gas: 1515037)
[PASS] testChainlogIntegrity() (gas: 6064192)
[PASS] testChainlogValues() (gas: 9989239)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDAIPayments() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30355917)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 2441054)
[SKIP] testMKRPayments() (gas: 0)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495577)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2823438)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testRwaConduitsPsmUpdate() (gas: 1586063)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testUseEta() (gas: 352730)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
[PASS] test_CRON_LITE_PSM_JOB() (gas: 2687681)
[PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588144)
Suite result: ok. 15 passed; 0 failed; 22 skipped; finished in 469.21s (1097.08s CPU time)

Ran 2 test suites in 469.86s (509.22s CPU time): 17 tests passed, 0 failed, 22 skipped (39 total tests)

[SidestreamColdMelon]

Handover and Merge Stage

• Check that the spell address posted by the crafter in new-spells is correct
• Confirm the address in the new-spells channel (via a separate "reply to" message, restating the address to avoid edits)
  • Wait until responsible governance facilitator confirms handover in new-spells
• Ensure that no changes were made to the code since the spell was deployed and archived
• Approve spell PR for merge via 'Approve' review option

[0xp3th1um]

Handover and Merge Stage

• Check that the spell address posted by the crafter in new-spells is correct
• Confirm the address in the new-spells channel (via a separate "reply to" message, restating the address to avoid edits)
  • Wait until responsible governance facilitator confirms handover in new-spells
• Ensure that no changes were made to the code since the spell was deployed and archived
• Approve spell PR for merge via 'Approve' review option