-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make exec-hash script #424
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions.
scripts/hash-exec-copy.py
Outdated
f"Executive%20vote%20-%20{date.strftime('%B %d, %Y')}.md", | ||
f"Executive%20Vote%20-%20{date.strftime('%B %d, %Y')}.md", | ||
f"Executive%20vote%20-%20{date.strftime('%B %-d, %Y')}.md", | ||
f"Executive%20Vote%20-%20{date.strftime('%B %-d, %Y')}.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SidestreamStrongStrawberry Could you please provide 4 command examples to test those 4 edge cases (as I assume you did it yourself)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it seems to not work with the latest spell:
Here's the URL for it:
https://github.com/makerdao/community/blob/master/governance/votes/templates/Executive%20vote%20-%20September%2013%2C%202024.md
I believe you need to URL-encode the formatted date for this to work prolerly. |
This can be improved but I don't think it affects the result. The hash results matches with url: https://raw.githubusercontent.com/makerdao/community/23d01e9ea8e102d959e7b9bd1586cb4c31a8b812/governance/votes/Executive%20vote%20-%20September%2013,%202024.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving.
Closes #425
Context
Executive Vote
in exec doc name will make the script fail (Error: Executive vote not found
) as the script was develop to work withExecutive vote