Fade skip button for last page if fade last page is enabled

[willthink]

No description provided.

[mamaral]

I'm not a fan of this for two reasons - the first is this PR includes the changes from your other PR that was closed because the functionality already exists to customize the skip button and page control without adding additional code. The second is that fading out the skip button on the last page is a fundamentally different process than fading out the page control - and thus shouldn't be tied logically to it. Some people might want to fade the page control but not the skip button. Also, AFAIK, setting the alpha of the skip button wouldn't disable it - so it would still be selectable and thus would lead to some weirdness if someone tapped the spot where it used to be and the skip handler was called.

[willthink]

I agree. Fade the button is not good idea. Do you think which way is good to disable skip button at last? How about removeFromSuperview?
BTW,
Thanks for your comment, I really learn from it

[mamaral]

You could always set the enabled property to NO, although I don't know exactly what the use-case is you have in mind for this.

[willthink]

To me, I don't like the skip button shows up with the "Getting started" at the last page. So I want skip button to disappear when the page control fades.

[mamaral]

Do you want it to reappear if you scroll back from the last page to the previous pages, or be gone forever once you reach the last screen?

[willthink]

Yes, it should reappear if you scroll back

[mamaral]

I'll try and whip something up tonight for you.

[higueraalfredo]

How about something like this in - scrollViewDidScroll:

_pageControl.alpha = 1.0 - percentComplete;
if (percentComplete >= 1.0) {
    _skipButton.enabled = NO;
    [UIView transitionWithView:_skipButton
                      duration:0.1
                       options:UIViewAnimationOptionTransitionCrossDissolve
                    animations:^{
                        _skipButton.hidden = YES;
                    }
                    completion:NULL];
}

[mamaral]

We definitely don't want to do a UIView animation inside that scrollViewDidScroll: as that is called a huge amount of times. I have a pretty simple solution, I just need to get the time to implement it.

[higueraalfredo]

Wouldn't checking if (percentComplete >= 1.0) make sure that the animation only fires once a page is fully loaded?
I agree with you that hiding the skip button should not be tied to fadePageControlOnLastPage but I'll use this solution in the meantime until you get a chance to implement this feature. I want to hide both on the last page so this is good enough for now.
Thanks.

[mamaral]

@higueraalfredo: No, because lets say the user was dragging the page back and forth from 98% -> 100% of the scroll percentage, it would be firing constantly and would probably break.

I should have this feature added tonight.

[mamaral]

I believe what you're looking for was been added in version 2.1.7 after merging #84. You should be able to run a pod update and pull those changes in, and simply set fadeSkipButtonOnLastPage to YES on your OnboardingViewController.