Context of warnings is empty in JSON result #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mamuz, do you need anything else from me to have a look at this PR? |
|
Hi @cawolf, thanks for the PR and sorry for long waiting. Its merged, next days i will create a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, thanks for this great project.
When running the analyzer against our company source code, I noticed that the console logging differs from the JSON result file regarding the contexts of the warnings. While the file paths are being correctly printed in the console, the JSON file contains only empty arrays.
I traced it down to the inability of
json_encodeto callSplFileInfo::__toString(compare with http://stackoverflow.com/questions/401908/php-tostring-and-json-encode-not-playing-well-together ) and added a little wrapper class to overcome this issue.I appreciate any feedback and hope you will merge this to your codebase,
best regards,
Christian A. Wolf