Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2119 issue: use bytes.fromhex instead of binascii #2235

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

lakshayletsgo
Copy link
Contributor

@lakshayletsgo lakshayletsgo commented Jul 28, 2024

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

Copy link

google-cla bot commented Jul 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review July 28, 2024 18:57

CHANGELOG updated or no update needed, thanks! 😄

capa/rules/__init__.py Outdated Show resolved Hide resolved
lakshayletsgo and others added 2 commits July 30, 2024 22:46
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
@mr-tz
Copy link
Collaborator

mr-tz commented Jul 31, 2024

Please remove the unused import: codecs

@mr-tz
Copy link
Collaborator

mr-tz commented Aug 1, 2024

closes #2119

@mr-tz
Copy link
Collaborator

mr-tz commented Aug 6, 2024

Hello @lakshayletsgo, thanks for the improvement. Can you please address the outstanding code style issue so we can merge this?

@mr-tz mr-tz merged commit 87f6916 into mandiant:master Aug 9, 2024
25 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants