cli: link to rule names to capa rules website #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
|
related: #2100 |
|
it was really easy to use rich instead of tabulate. i thought there'd be more work but the switch should be painless. |
This comment was marked as resolved.
This comment was marked as resolved.
williballenthin
force-pushed
the
feat/cli-links
branch
2 times, most recently
from
7c2291e
to
8ed32ef
Compare
github-actions
bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
williballenthin
force-pushed
the
feat/cli-links
branch
2 times, most recently
from
cdf02ba
to
838dd3d
Compare
|
I've migrated default rendering to rich. It worked well, and I think we can migrate the other renderers, too. But, I'd propose we all try out this PR for a little bit, and if it works, then update the other renderers. |
williballenthin
force-pushed
the
feat/cli-links
branch
from
838dd3d
to
20981ef
Compare
mr-tz
approved these changes
Aug 29, 2024
s-ff
requested changes
Aug 29, 2024
closes mandiant#2319 Update index.html Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
williballenthin
force-pushed
the
feat/cli-links
branch
from
4133f68
to
ff27ca1
Compare
s-ff
approved these changes
Aug 29, 2024
closes #2337
closes #2319
Add modern terminal markup to hyperlink to resources on the web, like entries on the capa rules website.
To make this possible, use rich instead of tabulate to render tables.
Also update the canonical path to rules on the website, to: mandiant.github.io/rules/[rule name]/
Using the rule name from the rule header makes it very easy to generate links to the web pages, rather than using the filename of the rule.
Checklist