Use new Variant API for generated instrumentation filter file #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filters file for instrumentation tests
…ew Variant API Since the minimum AGP version bump, we can finally safely access the source directories across all supported versions
mannodermaus
force-pushed
the
feature/new-instrumentation-test-variant-api
branch
from
7524f11
to
6dec09e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been relying on the older Variant API for many years because of the minimum AGP requirement that didn't allow all versions to use the new Variant API. This has always been an okay compromise, but it seems like the latest versions of AGP and Gradle are more strict about implicit task dependencies and raise a fuss about it (see #334).
Since the upcoming version of the plugin raises the minimum AGP version to 8.0 anyway, we are finally free to make use of
androidComponents.onVariantsfor the instrumentation filters file.