Add local language support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukasmartinelli, could you help me, please? |
|
Are there any updates on this? Can I help or try to fix something? |
lukasmartinelli
approved these changes
Jun 25, 2018
1ec5
reviewed
Jul 3, 2018
index.js
Outdated
| @@ -34,7 +34,7 @@ function MapboxLanguage(options) { | |||
| } | |||
| }; | |||
| this._excludedLayerIds = options.excludedLayerIds || []; | |||
| this.supportedLanguages = options.supportedLanguages || ['en', 'es', 'fr', 'de', 'ru', 'zh', 'ar', 'pt']; | |||
| this.supportedLanguages = options.supportedLanguages || ['local', 'en', 'es', 'fr', 'de', 'ru', 'zh', 'ar', 'pt']; | |||
There was a problem hiding this comment.
I think it would be better to use mul (the ISO 639 code for “multilingual”) to represent this option, as the iOS and macOS map SDKs do (documentation). That way, all the supportedLanguages values are valid IETF language tags, which will avoid edge cases when implementing #5.
There was a problem hiding this comment.
I fully agree with you.
Fixed it.
Thanks!
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to solve #13