Prepare a new release #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect. I think jump to v1.0. |
|
@andrewharvey Hi, when v1.0 will be released? |
|
Any news on this? |
mourner
approved these changes
Aug 13, 2021
mourner
reviewed
Aug 13, 2021
README.md
Outdated
| var mapboxgl = require('mapbox-gl') | ||
| var MapboxLanguage = require('@mapbox/mapbox-gl-language'); | ||
| const mapboxgl = require('mapbox-gl') | ||
| const MapboxLanguage = require('@mapbox/mapbox-gl-language'); |
There was a problem hiding this comment.
Nit: should we use the ESM syntax for these examples instead of require?
There was a problem hiding this comment.
Good catch on the old code. Fixed.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares a new release of GL Language.
{name).Do we want to jump to v1.0.0? Technically, since this is on major version 0, we're free to introduce breaking changes, but I think it makes sense to bump the major version here. It doesn't seem like the API is going to change radically so we can solidify it with the 1.0 release.
cc @andrewharvey