Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update language when changing style #46

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Update language when changing style #46

merged 1 commit into from
Aug 12, 2021

Conversation

ryanhamley
Copy link
Contributor

Closes #26

@ryanhamley ryanhamley self-assigned this Mar 5, 2021
@mdunisch
Copy link

please merge this and publish a new npm version.

At the moment this plugins is not useable when we use a style

@WilliamPriorielloGarda
Copy link

If this solution is correct, we are also waiting on it in a new npm version.
Thanks

@nasreddineskandrani
Copy link

Hi @ryanhamley,
Can you please proceed with this merge?

Thank you in advance

SnailBones
SnailBones approved these changes Aug 9, 2021
View reviewed changes
Copy link

@SnailBones SnailBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ryanhamley ryanhamley merged commit 56fe78a into master Aug 12, 2021
@ryanhamley ryanhamley deleted the update-language-on-style-change branch August 12, 2021 20:36
@nasreddineskandrani
Copy link

thanks

@ryanhamley
Copy link
Contributor Author

Thanks for the patience everyone. I'm working on getting a new release out asap.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnailBones SnailBones SnailBones approved these changes

Assignees

@ryanhamley ryanhamley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the style of the map changes, the map is always translated in "English".
5 participants
@ryanhamley @mdunisch @WilliamPriorielloGarda @nasreddineskandrani @SnailBones