Skip to content

Commit

Permalink
Merge pull request #201 from mapbox/unbundle3
Browse files Browse the repository at this point in the history
Unbundled deps and document how to avoid needing to bundle node-pre-gyp
  • Loading branch information
Dane Springmeyer committed Apr 6, 2016
2 parents 11a1ec4 + c714709 commit 5d9ef81
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 25 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# node-pre-gyp changelog

## 0.6.27

- Stopped bundling dependencies
- Documented method for module authors to avoid bundling node-pre-gyp
- See https://github.com/mapbox/node-pre-gyp/tree/master#configuring for details

## 0.6.26

- Skip validation for nw runtime (https://github.com/mapbox/node-pre-gyp/pull/181) via @fleg
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ This is a guide to configuring your module to use node-pre-gyp.

#### 1) Add new entries to your `package.json`

- Add `node-pre-gyp` to `bundledDependencies`
- Add `node-pre-gyp` to `dependencies`
- Add `aws-sdk` as a `devDependency`
- Add a custom `install` script
- Declare a `binary` object
Expand All @@ -101,14 +101,14 @@ This looks like:

```js
"dependencies" : {
"node-pre-gyp": "0.5.x"
"node-pre-gyp": "0.7.x"
},
"bundledDependencies":["node-pre-gyp"],
"devDependencies": {
"aws-sdk": "~2.0.0-rc.15"
"aws-sdk": "2.x"
}
"scripts": {
"install": "node-pre-gyp install --fallback-to-build",
"preinstall": "npm install node-pre-gyp",
"install": "node-pre-gyp install --fallback-to-build"
},
"binary": {
"module_name": "your_module",
Expand Down
29 changes: 9 additions & 20 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "node-pre-gyp",
"description": "Node.js native addon binary install tool",
"version" : "0.6.25",
"version": "0.7.0",
"keywords": [
"native",
"addon",
Expand All @@ -20,29 +20,18 @@
"bin": "./bin/node-pre-gyp",
"main": "./lib/node-pre-gyp.js",
"dependencies": {
"mkdirp": "~0.5.0",
"nopt": "~3.0.1",
"npmlog": "~2.0.0",
"rc": "~1.1.0",
"request": "2.x",
"rimraf": "~2.5.0",
"semver": "~5.1.0",
"tar": "~2.2.0",
"tar-pack": "~3.1.0",
"mkdirp": "~0.5.0",
"rc": "~1.1.0",
"rimraf": "~2.5.0"
"tar-pack": "~3.1.0"
},
"bundledDependencies":[
"nopt",
"npmlog",
"request",
"semver",
"tar",
"tar-pack",
"mkdirp",
"rc",
"rimraf"
],
"devDependencies": {
"aws-sdk":"2.x",
"aws-sdk": "2.x",
"mocha": "2.x",
"retire": "1.x",
"jshint": "2.x"
Expand All @@ -56,8 +45,8 @@
"mocha": true
},
"scripts": {
"prepublish":"retire -n && npm ls && jshint test/build.test.js test/s3_setup.test.js test/versioning.test.js",
"update-crosswalk":"node scripts/abi_crosswalk.js",
"test":"jshint lib lib/util scripts bin/node-pre-gyp && mocha -R spec --timeout 500000"
"prepublish": "retire -n && npm ls && jshint test/build.test.js test/s3_setup.test.js test/versioning.test.js",
"update-crosswalk": "node scripts/abi_crosswalk.js",
"test": "jshint lib lib/util scripts bin/node-pre-gyp && mocha -R spec --timeout 500000"
}
}

0 comments on commit 5d9ef81

Please sign in to comment.