Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade devDependencies #879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade devDependencies #879

wants to merge 1 commit into from

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jul 23, 2024

These are simply major version upgrades to keep the library using modern tooling in its testing setup.

This has no effect on consumers of the library since it updates devDependencies, which only affects developers of this library (and the CI). Consumers of the library are only affected by changes to the dependencies in package.json

There were a couple I left out because they would be more complicated and would be better to handle separately. codecov has been deprecated and replaced with a GitHub action. The eslint upgrade requires updating the config file, but first the common mapbox config must be updated.

@cclauss cclauss requested a review from lukekarrys July 23, 2024 16:02
@benmccann benmccann changed the title upgrade nyc upgrade devDependencies Jul 23, 2024
@benmccann
Copy link
Contributor Author

@lukekarrys could I ask for a quick peek at this one?

@benmccann
Copy link
Contributor Author

@cclauss would you be able to take a look at this PR?

@lukekarrys
Copy link
Collaborator

Apologies for going MIA on this repo and my responsibilities I promised to take on. My goal is to take a look at everything this weekend, and I have carved on time to do so! 🙌🏼

@cclauss
Copy link
Collaborator

cclauss commented Aug 22, 2024

I know the feeling. I have the same issues as you on several Python repos. It is difficult to do the day job and then also do this volunteer work. This is especially true during beautiful summer daze in the gorgeous Swiss Alps!

Thanks massively for your efforts. I am delighted that you have the skills that I lack and are willing to dedicate some time to getting this project back on track.

@benmccann
Copy link
Contributor Author

Thanks @lukekarrys!

@benmccann
Copy link
Contributor Author

@lukekarrys I thought I'd check back in and see if you might have a chance to lend a pair of eyes to this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants