Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render tests due to environment change #1009

Closed
wants to merge 4 commits into from
Closed

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Feb 18, 2022

Launch Checklist

The following indicate a change in the ubuntu environment yesterday:
https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu1804-Readme.md
Which I believe is the root cause of the render test failure.
I'll see if I can make them pass as part of this PR...

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Manually test the debug page.
  • Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
  • Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2022

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 185 kB 185 kB 0 B
maplibre-gl.css 9.25 kB 9.25 kB 0 B
ℹ️ View Details No major changes

@HarelM HarelM changed the title Ignore this! Fix render tests due to environment change Feb 18, 2022
@HarelM
Copy link
Collaborator Author

HarelM commented Feb 18, 2022

@astridx in the above run I've added to the artifacts the failed tests with the actual image that was created in the CI server while running the 6 failing tests.
The html file can be found here:
https://github.com/maplibre/maplibre-gl-js/actions/runs/1864381789
When I open it and save the image instead of the expected image git doesn't think there's a change in the file for some reason.
Can you see if you can help out and maybe force git somehow to change the files?
image
If this doesn't work we can change the threshold a bit I guess...?
Any help would be appreciated...

@HarelM HarelM mentioned this pull request Feb 18, 2022
1 task
@astridx
Copy link
Contributor

astridx commented Feb 19, 2022

@HarelM I'm afraid I don't understand the problem exactly.

(You probably ask me because I work with Ubuntu. My machine has Ubuntu 20.04. The CI image you refer to is Ubuntu 18.04. What exactly has been changed in the CI image I do not understand.)

I have just run the test directories that fail in the CI. All of them are successful for me. I have attached the result here. I added .log to the filename, because .html is not allowed.

Does this help or can you tell me what I would do better?

index.html.log

@HarelM
Copy link
Collaborator Author

HarelM commented Feb 19, 2022

It will be solved by #1003 in any case...

@HarelM HarelM closed this Feb 19, 2022
@HarelM HarelM deleted the test-render-break branch February 20, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants