Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ts-node to 10.9, allow node 18, fix json import assert #1431

Merged
merged 15 commits into from
Aug 5, 2022
Merged

Bump ts-node to 10.9, allow node 18, fix json import assert #1431

merged 15 commits into from
Aug 5, 2022

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Aug 5, 2022 •
edited
Loading

Compatibility with node 16 and 18 interchangeably.

Changes:

  • Ts-node is bumped to 10.9 - that cause that we needed to add some import assert type json statements.
  • Jest couldn't manage that, so now instead of having the jest tests do type checking, they only execute the code, and a separate typecheck command is now package.json instead using tsc, and also a github test runner for the CI/CD. This is actually better as theres no point in running a full typecheck for all 122 unit tests...
  • Rollup couldn't handle the json import statements either, so a new plugin was added for that.

@birkskyum birkskyum changed the title Update ts node to 10.9 Update ts node to 10.9, allow for node 18, fix json import assertion issues. Aug 5, 2022
@birkskyum birkskyum changed the title Update ts node to 10.9, allow for node 18, fix json import assertion issues. Bump ts-node to 10.9, allow node 18, fix json import assert Aug 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022 •
edited
Loading

Bundle size report:

Size Change: 0 B
Total Size Before: 203 kB
Total Size After: 203 kB

Output file Before After Change
maplibre-gl.js 193 kB 193 kB 0 B
maplibre-gl.css 9.65 kB 9.65 kB 0 B
ℹ️ View Details
Source file Before After Change
src/symbol/one_em.ts 29 B 0 B -29 B
src/data/extent.ts 32 B 0 B -32 B
src/util/web_worker.ts 40 B 0 B -40 B
src/style-spec/validate/validate_paint_property.ts 54 B 0 B -54 B
src/style-spec/validate/validate_layout_property.ts 55 B 0 B -55 B
src/shaders/clipping_mask.fragment.glsl.g.ts 61 B 0 B -61 B
src/style-spec/validate/validate_formatted.ts 62 B 0 B -62 B
src/style-spec/validate/validate_image.ts 63 B 0 B -63 B
src/style/style_layer/background_style_layer.ts 63 B 0 B -63 B
src/style/style_layer/raster_style_layer.ts 63 B 0 B -63 B
node_modules/murmurhash-js/index.js 67 B 0 B -67 B
src/style-spec/util/ref_properties.ts 68 B 0 B -68 B
src/data/pos_attributes.ts 80 B 0 B -80 B
src/style-spec/util/result.ts 81 B 0 B -81 B
src/shaders/encode_attribute.ts 81 B 0 B -81 B
src/data/bucket/heatmap_bucket.ts 82 B 0 B -82 B
src/util/config.ts 83 B 0 B -83 B
src/style-spec/util/extend.ts 83 B 0 B -83 B
node_modules/@mapbox/vector-tile/index.js 89 B 0 B -89 B
src/style-spec/expression/parsing_error.ts 91 B 0 B -91 B
src/data/bucket/circle_attributes.ts 92 B 0 B -92 B
src/data/bucket/fill_attributes.ts 92 B 0 B -92 B
src/data/raster_bounds_attributes.ts 93 B 0 B -93 B
src/data/evaluation_feature.ts 96 B 0 B -96 B
src/util/resolve_tokens.ts 97 B 0 B -97 B
src/render/program/clipping_mask_program.ts 100 B 0 B -100 B
src/data/bucket/line_attributes_ext.ts 102 B 0 B -102 B
src/source/pixels_to_tile_units.ts 104 B 0 B -104 B
src/ui/handler/handler_util.ts 104 B 0 B -104 B
src/shaders/clipping_mask.vertex.glsl.g.ts 105 B 0 B -105 B
src/shaders/background.vertex.glsl.g.ts 106 B 0 B -106 B
src/shaders/terrain.fragment.glsl.g.ts 110 B 0 B -110 B
src/style-spec/expression/runtime_error.ts 111 B 0 B -111 B
src/style-spec/validate/validate_constants.ts 113 B 0 B -113 B
src/style/style_layer/background_style_layer_properties.g.ts 115 B 0 B -115 B
src/data/bucket/line_attributes.ts 119 B 0 B -119 B
src/shaders/fill_extrusion.fragment.glsl.g.ts 119 B 0 B -119 B
src/style-spec/validate/validate_string.ts 122 B 0 B -122 B
src/style-spec/validate/validate_boolean.ts 123 B 0 B -123 B
src/style/style_image.ts 125 B 0 B -125 B
src/style/style_layer/heatmap_style_layer_properties.g.ts 131 B 0 B -131 B
src/style-spec/expression/types/resolved_image.ts 132 B 0 B -132 B
src/style-spec/util/get_type.ts 132 B 0 B -132 B
src/data/bucket/fill_extrusion_attributes.ts 134 B 0 B -134 B
src/shaders/hillshade.vertex.glsl.g.ts 136 B 0 B -136 B
src/gl/depth_mode.ts 136 B 0 B -136 B
src/shaders/background.fragment.glsl.g.ts 137 B 0 B -137 B
src/data/bucket/pattern_attributes.ts 138 B 0 B -138 B
src/style/style_layer/hillshade_style_layer.ts 139 B 0 B -139 B
src/util/throttle.ts 142 B 0 B -142 B
src/style-spec/validate/validate_color.ts 143 B 0 B -143 B
src/shaders/heatmap_texture.vertex.glsl.g.ts 143 B 0 B -143 B
src/shaders/_prelude.fragment.glsl.g.ts 145 B 0 B -145 B
src/shaders/debug.fragment.glsl.g.ts 147 B 0 B -147 B
src/shaders/collision_box.fragment.glsl.g.ts 148 B 0 B -148 B
src/ui/handler/shim/dblclick_zoom.ts 149 B 0 B -149 B
src/gl/stencil_mode.ts 151 B 0 B -151 B
src/util/dictionary_coder.ts 153 B 0 B -153 B
node_modules/gl-matrix/esm/quat.js 154 B 0 B -154 B
src/style-spec/util/properties.ts 155 B 0 B -155 B
src/style/validate_style.ts 155 B 0 B -155 B
src/util/offscreen_canvas_supported.ts 155 B 0 B -155 B
src/style-spec/empty.ts 155 B 0 B -155 B
src/gl/cull_face_mode.ts 156 B 0 B -156 B
src/util/debug.ts 161 B 0 B -161 B
src/shaders/debug.vertex.glsl.g.ts 163 B 0 B -163 B
src/style/style_layer/hillshade_style_layer_properties.g.ts 164 B 0 B -164 B
src/style/style_layer/raster_style_layer_properties.g.ts 167 B 0 B -167 B
src/style-spec/validate/validate_glyphs_url.ts 169 B 0 B -169 B
src/symbol/anchor.ts 169 B 0 B -169 B
src/shaders/terrain_coords.fragment.glsl.g.ts 170 B 0 B -170 B
src/shaders/fill.vertex.glsl.g.ts 171 B 0 B -171 B
src/shaders/terrain.vertex.glsl.g.ts 172 B 0 B -172 B
src/gl/color_mode.ts 174 B 0 B -174 B
src/shaders/fill.fragment.glsl.g.ts 178 B 0 B -178 B
src/ui/handler/shim/drag_rotate.ts 178 B 0 B -178 B
src/style-spec/util/unbundle_jsonlint.ts 180 B 0 B -180 B
src/style/zoom_history.ts 181 B 0 B -181 B
node_modules/gl-matrix/esm/common.js 181 B 0 B -181 B
src/style/style_layer/fill_extrusion_style_layer_properties.g.ts 182 B 0 B -182 B
node_modules/@mapbox/vector-tile/lib/vectortile.js 186 B 0 B -186 B
src/style-spec/expression/stops.ts 189 B 0 B -189 B
src/render/program/debug_program.ts 191 B 0 B -191 B
src/shaders/hillshade_prepare.vertex.glsl.g.ts 192 B 0 B -192 B
src/style-spec/expression/scope.ts 195 B 0 B -195 B
src/style-spec/util/deep_equal.ts 195 B 0 B -195 B
src/data/bucket.ts 195 B 0 B -195 B
src/style/style_layer/fill_style_layer_properties.g.ts 196 B 0 B -196 B
src/shaders/terrain_depth.fragment.glsl.g.ts 196 B 0 B -196 B
src/symbol/transform_text.ts 202 B 0 B -202 B
src/shaders/raster.vertex.glsl.g.ts 202 B 0 B -202 B
src/style-spec/expression/types/collator.ts 204 B 0 B -204 B
node_modules/gl-matrix/esm/mat2.js 204 B 0 B -204 B
src/shaders/heatmap_texture.fragment.glsl.g.ts 206 B 0 B -206 B
src/style-spec/validate/validate_enum.ts 208 B 0 B -208 B
src/style-spec/deref.ts 208 B 0 B -208 B
src/util/throttled_invoker.ts 214 B 0 B -214 B
src/ui/anchor.ts 217 B 0 B -217 B
src/shaders/fill_outline.vertex.glsl.g.ts 218 B 0 B -218 B
src/style/load_glyph_range.ts 221 B 0 B -221 B
src/gl/framebuffer.ts 221 B 0 B -221 B
src/style-spec/validate/validate_number.ts 222 B 0 B -222 B
src/ui/handler/shim/drag_pan.ts 222 B 0 B -222 B
src/style/style_layer/circle_style_layer_properties.g.ts 226 B 0 B -226 B
src/shaders/background_pattern.vertex.glsl.g.ts 226 B 0 B -226 B
src/shaders/symbol_icon.fragment.glsl.g.ts 226 B 0 B -226 B
src/style-spec/util/interpolate.ts 232 B 0 B -232 B
src/util/smart_wrap.ts 234 B 0 B -234 B
src/ui/handler/click_zoom.ts 240 B 0 B -240 B
src/style-spec/validate/validate_padding.ts 241 B 0 B -241 B
src/style-spec/validate/validate_terrain.ts 242 B 0 B -242 B
src/util/classify_rings.ts 246 B 0 B -246 B
src/util/vectortile_to_geojson.ts 250 B 0 B -250 B
src/style-spec/expression/is_constant.ts 254 B 0 B -254 B
src/shaders/fill_outline.fragment.glsl.g.ts 254 B 0 B -254 B
src/data/load_geometry.ts 255 B 0 B -255 B
src/style-spec/util/padding.ts 257 B 0 B -257 B
src/shaders/collision_circle.fragment.glsl.g.ts 258 B 0 B -258 B
node_modules/kdbush/src/range.js 262 B 0 B -262 B
src/style-spec/expression/types/formatted.ts 265 B 0 B -265 B
node_modules/murmurhash-js/murmurhash2_gc.js 265 B 0 B -265 B
src/util/task_queue.ts 265 B 0 B -265 B
src/shaders/heatmap.fragment.glsl.g.ts 266 B 0 B -266 B
src/source/load_tilejson.ts 271 B 0 B -271 B
src/style-spec/expression/definitions/image.ts 274 B 0 B -274 B
node_modules/geojson-vt/src/transform.js 274 B 0 B -274 B
src/style/style_layer/fill_style_layer.ts 277 B 0 B -277 B
node_modules/@mapbox/whoots-js/index.mjs 278 B 0 B -278 B
node_modules/geojson-vt/src/simplify.js 278 B 0 B -278 B
src/style/style_layer/line_style_layer_properties.g.ts 279 B 0 B -279 B
node_modules/gl-matrix/esm/vec2.js 280 B 0 B -280 B
src/symbol/check_max_angle.ts 286 B 0 B -286 B
src/ui/handler/shim/touch_zoom_rotate.ts 289 B 0 B -289 B
src/style-spec/validate/validate_light.ts 290 B 0 B -290 B
src/style-spec/validate_style.min.ts 291 B 0 B -291 B
src/shaders/background_pattern.fragment.glsl.g.ts 295 B 0 B -295 B
src/gl/index_buffer.ts 297 B 0 B -297 B
node_modules/geojson-vt/src/feature.js 300 B 0 B -300 B
src/symbol/clip_line.ts 302 B 0 B -302 B
node_modules/gl-matrix/esm/mat3.js 303 B 0 B -303 B
src/symbol/path_interpolator.ts 310 B 0 B -310 B
src/style-spec/expression/evaluation_context.ts 311 B 0 B -311 B
src/style/format_section_override.ts 311 B 0 B -311 B
src/ui/default_locale.ts 311 B 0 B -311 B
src/style-spec/expression/definitions/literal.ts 312 B 0 B -312 B
src/shaders/collision_box.vertex.glsl.g.ts 313 B 0 B -313 B
src/style-spec/util/color.ts 316 B 0 B -316 B
src/source/tile_bounds.ts 316 B 0 B -316 B
src/style-spec/expression/definitions/var.ts 320 B 0 B -320 B
src/util/color_ramp.ts 320 B 0 B -320 B
src/data/bucket/pattern_bucket_features.ts 324 B 0 B -324 B
src/shaders/line.fragment.glsl.g.ts 325 B 0 B -325 B
src/render/glyph_atlas.ts 328 B 0 B -328 B
src/util/global_worker_pool.ts 330 B 0 B -330 B
src/util/dispatcher.ts 331 B 0 B -331 B
src/style-spec/expression/definitions/length.ts 332 B 0 B -332 B
src/style/create_style_layer.ts 332 B 0 B -332 B
node_modules/kdbush/src/within.js 332 B 0 B -332 B
src/render/draw_custom.ts 338 B 0 B -338 B
node_modules/@mapbox/geojson-rewind/index.js 341 B 0 B -341 B
src/geo/mercator_coordinate.ts 346 B 0 B -346 B
node_modules/quickselect/index.js 349 B 0 B -349 B
src/shaders/line_gradient.fragment.glsl.g.ts 350 B 0 B -350 B
node_modules/murmurhash-js/murmurhash3_gc.js 351 B 0 B -351 B
src/util/request_manager.ts 351 B 0 B -351 B
node_modules/potpack/index.mjs 353 B 0 B -353 B
src/style/style_layer/heatmap_style_layer.ts 353 B 0 B -353 B
src/source/source.ts 353 B 0 B -353 B
src/ui/events.ts 356 B 0 B -356 B
src/style-spec/validate/validate_array.ts 358 B 0 B -358 B
node_modules/tinyqueue/index.js 361 B 0 B -361 B
src/style/parse_glyph_pbf.ts 366 B 0 B -366 B
src/source/geojson_wrapper.ts 366 B 0 B -366 B
src/ui/handler/tap_zoom.ts 366 B 0 B -366 B
src/source/raster_dem_tile_worker_source.ts 368 B 0 B -368 B
node_modules/kdbush/src/index.js 368 B 0 B -368 B
src/shaders/heatmap.vertex.glsl.g.ts 369 B 0 B -369 B
src/util/webp_supported.ts 374 B 0 B -374 B
src/style-spec/expression/definitions/at.ts 376 B 0 B -376 B
node_modules/kdbush/src/sort.js 376 B 0 B -376 B
src/style-spec/expression/definitions/collator.ts 385 B 0 B -385 B
src/symbol/collision_feature.ts 386 B 0 B -386 B
src/style/evaluation_parameters.ts 387 B 0 B -387 B
src/shaders/fill_pattern.vertex.glsl.g.ts 387 B 0 B -387 B
src/style-spec/validate/validate_object.ts 392 B 0 B -392 B
src/shaders/fill_pattern.fragment.glsl.g.ts 395 B 0 B -395 B
src/symbol/merge_lines.ts 403 B 0 B -403 B
src/style-spec/group_by_layout.ts 407 B 0 B -407 B
src/style/load_sprite.ts 410 B 0 B -410 B
src/shaders/circle.fragment.glsl.g.ts 410 B 0 B -410 B
src/shaders/fill_outline_pattern.vertex.glsl.g.ts 415 B 0 B -415 B
src/shaders/fill_extrusion_pattern.fragment.glsl.g.ts 415 B 0 B -415 B
src/style-spec/validate/validate.ts 416 B 0 B -416 B
src/shaders/fill_outline_pattern.fragment.glsl.g.ts 418 B 0 B -418 B
src/util/worker_pool.ts 419 B 0 B -419 B
src/style-spec/expression/definitions/coalesce.ts 422 B 0 B -422 B
src/style-spec/expression/definitions/in.ts 425 B 0 B -425 B
node_modules/@mapbox/unitbezier/index.js 426 B 0 B -426 B
src/geo/edge_insets.ts 427 B 0 B -427 B
src/ui/handler/map_event.ts 431 B 0 B -431 B
node_modules/@mapbox/vector-tile/lib/vectortilelayer.js 432 B 0 B -432 B
src/style-spec/expression/definitions/let.ts 436 B 0 B -436 B
src/style-spec/expression/definitions/case.ts 437 B 0 B -437 B
src/shaders/raster.fragment.glsl.g.ts 438 B 0 B -438 B
src/style-spec/expression/definitions/slice.ts 443 B 0 B -443 B
src/util/browser.ts 451 B 0 B -451 B
src/data/segment.ts 451 B 0 B -451 B
src/style-spec/validate/validate_expression.ts 452 B 0 B -452 B
src/ui/control/terrain_control.ts 455 B 0 B -455 B
src/style/style_layer_index.ts 457 B 0 B -457 B
src/render/program/circle_program.ts 459 B 0 B -459 B
src/shaders/line_sdf.fragment.glsl.g.ts 460 B 0 B -460 B
node_modules/vt-pbf/lib/geojson_wrapper.js 463 B 0 B -463 B
node_modules/geojson-vt/src/wrap.js 464 B 0 B -464 B
src/render/program/background_program.ts 473 B 0 B -473 B
src/ui/handler/tap_drag_zoom.ts 481 B 0 B -481 B
src/style/query_utils.ts 483 B 0 B -483 B
src/style-spec/expression/definitions/index_of.ts 491 B 0 B -491 B
src/style/style_layer/custom_style_layer.ts 491 B 0 B -491 B
src/shaders/hillshade_prepare.fragment.glsl.g.ts 500 B 0 B -500 B
src/ui/control/logo_control.ts 503 B 0 B -503 B
src/util/evented.ts 506 B 0 B -506 B
src/style-spec/expression/values.ts 507 B 0 B -507 B
src/style-spec/expression/types.ts 513 B 0 B -513 B
src/style-spec/expression/definitions/number_format.ts 527 B 0 B -527 B
node_modules/gl-matrix/esm/vec4.js 531 B 0 B -531 B
src/style/style_layer/circle_style_layer.ts 531 B 0 B -531 B
src/ui/handler/tap_recognizer.ts 535 B 0 B -535 B
src/gl/vertex_buffer.ts 539 B 0 B -539 B
src/ui/handler/touch_pan.ts 540 B 0 B -540 B
src/shaders/collision_circle.vertex.glsl.g.ts 547 B 0 B -547 B
src/style-spec/validate/validate_property.ts 549 B 0 B -549 B
src/shaders/symbol_sdf.fragment.glsl.g.ts 554 B 0 B -554 B
src/source/tile_cache.ts 555 B 0 B -555 B
src/shaders/hillshade.fragment.glsl.g.ts 555 B 0 B -555 B
src/ui/handler/mouse.ts 555 B 0 B -555 B
src/shaders/circle.vertex.glsl.g.ts 557 B 0 B -557 B
src/style/light.ts 560 B 0 B -560 B
src/data/feature_position_map.ts 561 B 0 B -561 B
src/render/program/heatmap_program.ts 562 B 0 B -562 B
src/render/program/fill_program.ts 563 B 0 B -563 B
src/render/program/raster_program.ts 565 B 0 B -565 B
node_modules/ieee754/index.js 567 B 0 B -567 B
src/render/draw_background.ts 570 B 0 B -570 B
src/symbol/get_anchors.ts 571 B 0 B -571 B
src/ui/handler/keyboard.ts 571 B 0 B -571 B
src/render/uniform_binding.ts 572 B 0 B -572 B
src/symbol/symbol_size.ts 574 B 0 B -574 B
src/render/vertex_array_object.ts 580 B 0 B -580 B
src/style-spec/expression/definitions/assertion.ts 586 B 0 B -586 B
src/util/verticalize_punctuation.ts 586 B 0 B -586 B
src/geo/lng_lat.ts 586 B 0 B -586 B
src/style/pauseable_placement.ts 598 B 0 B -598 B
src/shaders/symbol_text_and_icon.fragment.glsl.g.ts 598 B 0 B -598 B
src/source/source_state.ts 602 B 0 B -602 B
src/render/program/terrain_program.ts 606 B 0 B -606 B
src/geo/lng_lat_bounds.ts 613 B 0 B -613 B
src/render/draw_circle.ts 614 B 0 B -614 B
src/render/program/pattern.ts 616 B 0 B -616 B
src/style-spec/validate/validate_source.ts 619 B 0 B -619 B
src/shaders/fill_extrusion.vertex.glsl.g.ts 620 B 0 B -620 B
src/style-spec/validate/validate_filter.ts 622 B 0 B -622 B
node_modules/@mapbox/point-geometry/index.js 630 B 0 B -630 B
src/style-spec/expression/definitions/step.ts 643 B 0 B -643 B
src/style-spec/expression/definitions/format.ts 650 B 0 B -650 B
src/style/style_layer/symbol_style_layer_properties.g.ts 650 B 0 B -650 B
src/util/dom.ts 658 B 0 B -658 B
src/util/image.ts 679 B 0 B -679 B
src/render/texture.ts 682 B 0 B -682 B
src/util/find_pole_of_inaccessibility.ts 688 B 0 B -688 B
src/render/program/fill_extrusion_program.ts 689 B 0 B -689 B
src/util/struct_array.ts 697 B 0 B -697 B
src/source/vector_tile_worker_source.ts 698 B 0 B -698 B
src/shaders/line_pattern.fragment.glsl.g.ts 706 B 0 B -706 B
src/shaders/line.vertex.glsl.g.ts 708 B 0 B -708 B
src/ui/handler/box_zoom.ts 716 B 0 B -716 B
src/render/program/collision_program.ts 726 B 0 B -726 B
src/util/primitives.ts 728 B 0 B -728 B
src/style-spec/expression/compound_expression.ts 733 B 0 B -733 B
src/style-spec/expression/definitions/coercion.ts 736 B 0 B -736 B
src/shaders/line_gradient.vertex.glsl.g.ts 739 B 0 B -739 B
src/ui/control/scale_control.ts 742 B 0 B -742 B
src/style-spec/expression/definitions/match.ts 749 B 0 B -749 B
src/style-spec/util/color_spaces.ts 759 B 0 B -759 B
src/data/bucket/symbol_attributes.ts 766 B 0 B -766 B
node_modules/geojson-vt/src/tile.js 782 B 0 B -782 B
src/util/performance.ts 786 B 0 B -786 B
src/shaders/line_pattern.vertex.glsl.g.ts 787 B 0 B -787 B
src/shaders/line_sdf.vertex.glsl.g.ts 807 B 0 B -807 B
src/style/style_layer/line_style_layer.ts 815 B 0 B -815 B
src/util/actor.ts 815 B 0 B -815 B
src/ui/handler_inertia.ts 820 B 0 B -820 B
src/shaders/fill_extrusion_pattern.vertex.glsl.g.ts 829 B 0 B -829 B
src/render/image_atlas.ts 833 B 0 B -833 B
src/data/dem_data.ts 833 B 0 B -833 B
src/render/draw_fill_extrusion.ts 837 B 0 B -837 B
src/style-spec/expression/definitions/comparison.ts 839 B 0 B -839 B
node_modules/geojson-vt/src/convert.js 851 B 0 B -851 B
src/ui/control/fullscreen_control.ts 855 B 0 B -855 B
src/index.ts 856 B 0 B -856 B
src/style-spec/validate/validate_layer.ts 864 B 0 B -864 B
src/render/render_to_texture.ts 867 B 0 B -867 B
node_modules/geojson-vt/src/clip.js 870 B 0 B -870 B
src/source/rtl_text_plugin.ts 875 B 0 B -875 B
src/source/video_source.ts 876 B 0 B -876 B
src/util/is_char_in_unicode_block.ts 880 B 0 B -880 B
src/render/program/hillshade_program.ts 880 B 0 B -880 B
src/util/tile_request_cache.ts 882 B 0 B -882 B
src/style-spec/feature_filter/index.ts 889 B 0 B -889 B
src/source/raster_tile_source.ts 912 B 0 B -912 B
node_modules/gl-matrix/esm/vec3.js 914 B 0 B -914 B
src/style/style_layer/fill_extrusion_style_layer.ts 927 B 0 B -927 B
src/render/program/program_uniforms.ts 931 B 0 B -931 B
node_modules/vt-pbf/index.js 938 B 0 B -938 B
src/ui/hash.ts 940 B 0 B -940 B
src/util/intersection_tests.ts 941 B 0 B -941 B
src/render/glyph_manager.ts 946 B 0 B -946 B
src/shaders/symbol_icon.vertex.glsl.g.ts 949 B 0 B -949 B
src/util/web_worker_transfer.ts 950 B 0 B -950 B
src/source/worker.ts 953 B 0 B -953 B
src/shaders/_prelude.vertex.glsl.g.ts 963 B 0 B -963 B
src/source/terrain_source_cache.ts 966 B 0 B -966 B
src/source/raster_dem_tile_source.ts 970 B 0 B -970 B
src/data/bucket/circle_bucket.ts 971 B 0 B -971 B
node_modules/@mapbox/mapbox-gl-supported/index.js 974 B 0 B -974 B
src/render/line_atlas.ts 983 B 0 B -983 B
node_modules/@mapbox/vector-tile/lib/vectortilefeature.js 1.01 kB 0 B -1.01 kB
src/shaders/symbol_sdf.vertex.glsl.g.ts 1.01 kB 0 B -1.01 kB
src/shaders/symbol_text_and_icon.vertex.glsl.g.ts 1.01 kB 0 B -1.01 kB
src/util/transferable_grid_index.ts 1.02 kB 0 B -1.02 kB
src/render/draw_fill.ts 1.02 kB 0 B -1.02 kB
src/source/canvas_source.ts 1.02 kB 0 B -1.02 kB
src/ui/handler/touch_zoom_rotate.ts 1.03 kB 0 B -1.03 kB
src/style-spec/expression/parsing_context.ts 1.03 kB 0 B -1.03 kB
src/render/draw_heatmap.ts 1.04 kB 0 B -1.04 kB
src/render/draw_raster.ts 1.04 kB 0 B -1.04 kB
src/render/draw_line.ts 1.04 kB 0 B -1.04 kB
src/ui/control/attribution_control.ts 1.09 kB 0 B -1.09 kB
src/gl/value.ts 1.09 kB 0 B -1.09 kB
src/data/bucket/fill_bucket.ts 1.09 kB 0 B -1.09 kB
node_modules/@mapbox/tiny-sdf/index.js 1.1 kB 0 B -1.1 kB
src/source/vector_tile_source.ts 1.11 kB 0 B -1.11 kB
src/source/image_source.ts 1.11 kB 0 B -1.11 kB
src/render/draw_collision_debug.ts 1.13 kB 0 B -1.13 kB
src/render/draw_debug.ts 1.13 kB 0 B -1.13 kB
src/symbol/cross_tile_symbol_index.ts 1.13 kB 0 B -1.13 kB
src/source/tile_id.ts 1.14 kB 0 B -1.14 kB
src/render/program.ts 1.14 kB 0 B -1.14 kB
src/style/style_layer/symbol_style_layer.ts 1.14 kB 0 B -1.14 kB
src/style-spec/validate/validate_function.ts 1.15 kB 0 B -1.15 kB
src/render/draw_hillshade.ts 1.15 kB 0 B -1.15 kB
src/render/program/line_program.ts 1.16 kB 0 B -1.16 kB
src/style/style_layer.ts 1.21 kB 0 B -1.21 kB
src/source/query_features.ts 1.21 kB 0 B -1.21 kB
src/style-spec/function/index.ts 1.23 kB 0 B -1.23 kB
src/style-spec/expression/definitions/interpolate.ts 1.27 kB 0 B -1.27 kB
src/source/worker_tile.ts 1.28 kB 0 B -1.28 kB
src/ui/handler/scroll_zoom.ts 1.28 kB 0 B -1.28 kB
src/gl/context.ts 1.28 kB 0 B -1.28 kB
src/source/geojson_source.ts 1.28 kB 0 B -1.28 kB
src/render/program/symbol_program.ts 1.3 kB 0 B -1.3 kB
src/symbol/grid_index.ts 1.35 kB 0 B -1.35 kB
src/style-spec/expression/definitions/within.ts 1.37 kB 0 B -1.37 kB
src/render/image_manager.ts 1.4 kB 0 B -1.4 kB
src/data/bucket/fill_extrusion_bucket.ts 1.44 kB 0 B -1.44 kB
src/source/geojson_worker_source.ts 1.46 kB 0 B -1.46 kB
src/shaders/shaders.ts 1.49 kB 0 B -1.49 kB
src/style-spec/diff.ts 1.54 kB 0 B -1.54 kB
node_modules/geojson-vt/src/index.js 1.56 kB 0 B -1.56 kB
src/ui/control/navigation_control.ts 1.61 kB 0 B -1.61 kB
src/style-spec/expression/definitions/index.ts 1.63 kB 0 B -1.63 kB
src/util/script_detection.ts 1.64 kB 0 B -1.64 kB
src/symbol/collision_index.ts 1.64 kB 0 B -1.64 kB
src/style-spec/expression/index.ts 1.66 kB 0 B -1.66 kB
src/data/feature_index.ts 1.75 kB 0 B -1.75 kB
src/render/draw_terrain.ts 1.81 kB 0 B -1.81 kB
src/symbol/projection.ts 1.82 kB 0 B -1.82 kB
src/style/properties.ts 1.87 kB 0 B -1.87 kB
src/util/util.ts 1.87 kB 0 B -1.87 kB
src/symbol/quads.ts 1.89 kB 0 B -1.89 kB
src/ui/popup.ts 1.91 kB 0 B -1.91 kB
src/source/tile.ts 1.99 kB 0 B -1.99 kB
node_modules/csscolorparser/csscolorparser.js 2.06 kB 0 B -2.06 kB
node_modules/supercluster/index.js 2.07 kB 0 B -2.07 kB
src/render/terrain.ts 2.17 kB 0 B -2.17 kB
src/ui/control/geolocate_control.ts 2.26 kB 0 B -2.26 kB
src/util/ajax.ts 2.39 kB 0 B -2.39 kB
src/data/bucket/line_bucket.ts 2.41 kB 0 B -2.41 kB
src/ui/handler_manager.ts 2.47 kB 0 B -2.47 kB
src/render/draw_symbol.ts 2.59 kB 0 B -2.59 kB
src/data/program_configuration.ts 2.61 kB 0 B -2.61 kB
node_modules/gl-matrix/esm/mat4.js 2.73 kB 0 B -2.73 kB
node_modules/earcut/src/earcut.js 2.81 kB 0 B -2.81 kB
node_modules/pbf/index.js 2.81 kB 0 B -2.81 kB
src/data/array_types.g.ts 2.82 kB 0 B -2.82 kB
src/ui/marker.ts 2.88 kB 0 B -2.88 kB
src/ui/camera.ts 3 kB 0 B -3 kB
src/style-spec/error/validation_error.ts 3.57 kB 0 B -3.57 kB
src/symbol/shaping.ts 3.63 kB 0 B -3.63 kB
src/symbol/symbol_layout.ts 3.76 kB 0 B -3.76 kB
src/source/source_cache.ts 3.99 kB 0 B -3.99 kB
src/render/painter.ts 3.99 kB 0 B -3.99 kB
src/data/bucket/symbol_bucket.ts 4.26 kB 0 B -4.26 kB
src/geo/transform.ts 4.54 kB 0 B -4.54 kB
src/symbol/placement.ts 4.8 kB 0 B -4.8 kB
src/ui/map.ts 6.77 kB 0 B -6.77 kB
src/style/style.ts 6.86 kB 0 B -6.86 kB

@birkskyum birkskyum mentioned this pull request Aug 5, 2022
Closed
@birkskyum
Copy link
Member Author

birkskyum commented Aug 5, 2022 •
edited
Loading

Overall this is very close, but there is a bit of work left related to the unassert plugin. The inline assert tests take up 5 kb, so if we leave them in production they add that. We can also remove them altogether, or we figure out how fix the unassert plugin.

@HarelM
Copy link
Collaborator

HarelM commented Aug 5, 2022

I don't see a lot of value in asserting inside the code. The tests should cover the cases where assert is needed in my opinion...

@birkskyum
Copy link
Member Author

birkskyum commented Aug 5, 2022 •
edited
Loading

I actually managed to fix the plugin and forgot about it again. I made an upsteam PR a week ago unassert-js/rollup-plugin-unassert#8, but for now we can just use the fork i made.

@birkskyum
Copy link
Member Author

birkskyum commented Aug 5, 2022 •
edited
Loading

So now I believe we have everything working with node 18

I also think we should remove these asserts at some point, as they are starting to hold us back in different ways. I made a branch a few weeks back called remove-browserify where I commented all the node assert

@birkskyum birkskyum marked this pull request as ready for review August 5, 2022 17:38
HarelM
HarelM reviewed Aug 5, 2022
View reviewed changes
.github/workflows/typecheck.yml
node-version: 16
architecture: x64
- run: npm ci
- run: npm run typecheck
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this run tsc on the tests files as well?

Copy link
Member Author

@birkskyum birkskyum Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - it didn't. I have just now added a tsconfig.typecheck.json file so we can tailor the typecheck specifically to the areas we want, so now they are covered.

HarelM
HarelM approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of dependencies were added... While I believe this is needed we need to think how to reduce those in the future...

@birkskyum
Copy link
Member Author

birkskyum commented Aug 5, 2022 •
edited
Loading

Seems like a lot of dependencies were added... While I believe this is needed we need to think how to reduce those in the future...

Yes, 2 plugins (one depend on the other) to make rollup recognise the import assert. I expect it'll somehow be baked into rollup/typescript quite soon so we can remove them again.

@birkskyum birkskyum merged commit cb1741f into main Aug 5, 2022
@birkskyum birkskyum deleted the update-ts-node-to-10.9 branch August 5, 2022 18:07
@birkskyum birkskyum mentioned this pull request Aug 5, 2022
Closed
@birkskyum birkskyum mentioned this pull request Aug 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkskyum @HarelM