Don't scroll while clicking an embedded link

Close #1042
mar10 · Jan 31, 2021 · 4622015 · 4622015
1 parent f0109bf
commit 4622015
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
     passed to `toDict` on dragStart)
   * [Added] #1054 ext-filter tree.updateFilter()
   * [Fixed] #700 ext-filter Doing fuzzy filtering doesn't escape regex characters like the non fuzzy case
+  * [Fixed] #1042 Don't scroll while clicking an embedded link
   * [Fixed] #1045 re-init exception (grid-ext)
 
 # 2.37.0 / 2020-09-11

diff --git a/src/jquery.fancytree.js b/src/jquery.fancytree.js
@@ -5317,7 +5317,17 @@
 				if (isActive === flag) {
 					// Nothing to do
 					return _getResolvedPromise(node);
-				} else if (
+				}
+				// #1042: don't scroll between mousedown/-up when clicking an embedded link
+				if (
+					scroll &&
+					ctx.originalEvent &&
+					$(ctx.originalEvent.target).is("a,:checkbox")
+				) {
+					node.info("Not scrolling while clicking an embedded link.");
+					scroll = false;
+				}
+				if (
 					flag &&
 					!noEvents &&
 					this._triggerNodeEvent(