Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node height and XHTML #117

Closed
ovidiuisac opened this issue Jan 4, 2014 · 5 comments
Closed

Node height and XHTML #117

ovidiuisac opened this issue Jan 4, 2014 · 5 comments
Milestone

Comments

@ovidiuisac
Copy link

Hi.
I use DTD XHTML in my projects. But when use DTD XHTML, li (item node) has a height of 31px (replace default 18px height).
Correct this: remove display: inline-block; for span.fancytree-node (ui.fancytree.css).
Amazing plugin. Thanks.

@mar10
Copy link
Owner

mar10 commented Jan 4, 2014

That would be an easy change.
Have you checked compatibility on non-xhtml and different browsers?

@ovidiuisac
Copy link
Author

Yes. This bug occurs only for Firefox and Chrome. Rewrite css with: display: inherited; or display: inline; or simple remove.
Check with Firefox, Chrome and IE 9 (and 7 & 8 compatibility) with XHTML and non-XHTML. Works.
Also use a custom jquery-ui library (minified) with 47 kb size (replace default library with 368kb size).
Includes: jquery.ui.core.js, jquery.ui.widget.js, jquery.ui.mouse.js, jquery.ui.draggable.js, jquery.ui.resizable.js
Again: amazing plugin. Thanks.

@mar10 mar10 closed this as completed in 0040567 Mar 16, 2014
@mar10
Copy link
Owner

mar10 commented Mar 24, 2014

Original:

span.fancytree-node {
    display: inline-block;
}

This fixed it, but breaks indentation of ext-table nodes:

span.fancytree-node {
    display: inherit;
}

so the solution was to remove it altogether.

mar10 added a commit that referenced this issue Mar 24, 2014
@mar10 mar10 added this to the 2.0.0-9 milestone Apr 1, 2014
@mar10
Copy link
Owner

mar10 commented Apr 1, 2014

arghh... seems that now the skin-win8 is broken:
the select bar no longer has width 100%

@mar10 mar10 reopened this Apr 1, 2014
@mar10 mar10 removed waiting labels Apr 1, 2014
@mar10 mar10 closed this as completed in 0ae60fe Apr 1, 2014
@mar10
Copy link
Owner

mar10 commented Apr 1, 2014

This seems to work:

  1. no whitespace between lines in XHTML docstyles
  2. 100% wide selection bar in skin-win8
  3. proper indentation for table tree
span.fancytree-node {
    display: inherit; /* resolves to 'display: list-item;' for standard trees */
    width: 100%;
}
table.fancytree-container span.fancytree-node {
    display: inline-block; /* 'inherit' would result in table-cell, which doesn't indent */
}

@mar10 mar10 modified the milestones: 2.0.0beta, 2.0.0-9 May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants