Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding for "ul.fancytree-container li" causes gaps when filtering in hide mode #246

Closed
hellmanj opened this issue Jun 5, 2014 · 3 comments
Closed

Padding for "ul.fancytree-container li" causes gaps when filtering in hide mode #246

hellmanj opened this issue Jun 5, 2014 · 3 comments
Labels
bug css ext-filter patch
Milestone
2.x Backlog

Comments

@hellmanj
Copy link

hellmanj commented Jun 5, 2014

Padding for "ul.fancytree-container li" is set to "1px 0 0 0" which doesn't seem to serve any purpose and creates gaps between nodes when filtering in "hide" mode. You may need a large tree with many nodes to notice the gaps.

Can the padding be removed?
hellmanj added a commit to hellmanj/fancytree that referenced this issue Jun 6, 2014
@hellmanj
this commit fixes mar10#246
53e5410 
Padding for "ul.fancytree-container li" is set to "1px 0 0 0" which
doesn't seem to serve any purpose and creates gaps between nodes when
filtering in "hide" mode.  This takes out the padding
@mar10
Copy link
Owner

mar10 commented Jun 7, 2014

Thanks!
Could you post a screenshot of the effect (the gaps)?
(If you create a pull request for this, I will merge.)

@mar10 mar10 added bug labels Jun 10, 2014
@mar10 mar10 added this to the 2.x Backlog milestone Jun 10, 2014
@sbagchi
Copy link

sbagchi commented Jun 19, 2014

screen shot 2014-06-19 at 12 42 00 pm
I also had the same problem with the large tree. lefunque's solution worked for me. See attached screenshot.
Source code is here https://gist.github.com/sbagchi/2a154314f8a546e454a6

@mar10
Copy link
Owner

mar10 commented Jun 19, 2014

Yes, I will use @lefunque 's fix, but currently I have another branch that refactores the CSS. I would like to merge this first, to prevent conflicts.

mar10 added a commit that referenced this issue Jun 28, 2014
@mar10
Fix gaps when filtering in hide mode
fa3cb24 
Close #246
Patch by @lefunque
@mar10 mar10 mentioned this issue Aug 22, 2014
Closed
@mar10 mar10 closed this as completed in 81fc957 Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug css ext-filter patch
Projects
None yet
Milestone
2.x Backlog
Development

No branches or pull requests
3 participants
@mar10 @sbagchi @hellmanj