copy functions to data, fixes #1016 #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogibear9988
force-pushed
the
fix1016
branch
3 times, most recently
from
73fc605
to
866dfe4
Compare
|
@mar10 is this okay ? |
mar10
reviewed
Jul 11, 2020
Gruntfile.coffee
Outdated
| @@ -542,6 +542,8 @@ module.exports = (grunt) -> | |||
|
|
|||
| # Register tasks | |||
|
|
|||
| grunt.util.linefeed = '\n' | |||
There was a problem hiding this comment.
What should be achieved by this line, and how is this related to the topic?
If there's a good reason, I can add it separately, but it should not be connected to this PR commit.
There was a problem hiding this comment.
I added it, cause I test in Windows.
Without it I could not build
mar10
requested changes
Jul 11, 2020
done |
|
Merged - thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.